Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing a psbt and detecting whether it is complete is not consistent #30

Open
Fonta1n3 opened this issue Feb 17, 2021 · 0 comments
Open

Finalizing a psbt and detecting whether it is complete is not consistent #30

Fonta1n3 opened this issue Feb 17, 2021 · 0 comments

Comments

@Fonta1n3
Copy link
Contributor

Fonta1n3 commented Feb 17, 2021 •
edited
Loading

When checking if a psbt is completely signed the underlying Libwally code seems to be inconsistent. Feeding it the same completely signed psbt will return different values when checking whether it is complete or not. Also the returned final hex of the transaction can be invalid, I have noticed this behavior specifically with transactions which hold more then 3 p2wsh inputs.

ElementsProject/libwally-core#251
@Fonta1n3 Fonta1n3 changed the title Finalzing Finalizing a psbt and detecting whether it is complete is not consistent Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fonta1n3