Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed-point function restoration. #36

Open
27 of 35 tasks
vs49688 opened this issue May 18, 2024 · 1 comment
Open
27 of 35 tasks

Fixed-point function restoration. #36

vs49688 opened this issue May 18, 2024 · 1 comment
Assignees
@vs49688

Comments

@vs49688
Copy link
Collaborator

vs49688 commented May 18, 2024 •
edited
Loading

Some of these were removed a long time ago because reasons, and some were rewritten to use floats.
Add any missing, and de-float them.
@vs49688 vs49688 self-assigned this May 18, 2024
@vs49688
Copy link
Collaborator Author

vs49688 commented May 18, 2024

A note on BrFixedASin() - due to br_fixed_luf being unsigned, negative value cannot be represented, and as such this function differs from regular asin() when x < 0. The math still works, e.g. sin(6.16) ~= -0.12, but this is just something to be aware of:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vs49688 vs49688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vs49688