Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Implement target temperature actions for type=21 #17

Closed
dag81 opened this issue Dec 28, 2020 · 2 comments
Closed

Feature request: Implement target temperature actions for type=21 #17

dag81 opened this issue Dec 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@dag81
Copy link

dag81 commented Dec 28, 2020

What do you want to achieve? Is your feature request related to a problem?

Looking at the Miele API documentation, it looks like potentially there is a targetTemperature action, which I assume would allow the target set-point to be written to a type=21 device both for either the fridge or freezer?

An example use case why I am looking for this is our house knows from the occupation sensors, when to activate security lighting at lower levels, turn down heating in the building / activate security measures, etc.... It knows we are out for more than a day we are away, so it would make sense for it to turn the freezer to a more economical setting such as -18 rather than the -22 we run it at. If I have read the documentation correctly, then the implementation of the target_setpoints for each setpoint as a writable point, would facilitate it using these actions?

I am assuming hopefully not incorrectly that this is available, as the Miele app implements this (and you would have hoped for cost purposes and maintainability that it uses the same API).

It would make sense if implemented that setpoint's against freezers are protected against going above -18 in temperature and not lower than -30, just to protect the end devices.

A sensible range could be applied to the fridges as well, 3 to 7 say within the bindings code, prior to transmitting the request.

I was trying to locate the source code to have a look, and submit a possible adjustment after testing, but Im guessing this is closed source at the moment, hence a new feature request 🤞

@dag81 dag81 added the enhancement New feature or request label Dec 28, 2020
@BjoernLange
Copy link
Owner

Hi @dag81!

I was trying to locate the source code to have a look, and submit a possible adjustment after testing, but Im guessing this is closed source at the moment, hence a new feature request

The code is open sourced here. We are currently in the review process of getting the binding integrated into openHAB, the PR can be found here. Once the openHAB maintainers merged the PR we are happy about further contributions from the community. You can also have a look at the forum thread where we usually post updates.

Apart from that, we will check your feature request some time next year because we are all vacationing at the moment, I just had to make clear that the code is open-source 😉

@dag81
Copy link
Author

dag81 commented Dec 29, 2020

Hi @BjoernLange,

Many thanks - I spent ages searching around, and kept missing that! Enjoy the well deserved vacation time!

@dag81 dag81 closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants