RPC client conversion table and RPC server named arguments mismatch for gettxoutsetinfo

[gitcoindev]

Hi, I am reporting this issue while working on #63

Detected by failing test:

File "test/functional/rpc_help.py", line 71, in test_client_conversion_table
raise AssertionError("RPC client conversion table ({}) and RPC server named arguments mismatch!\n{}".format(
AssertionError: RPC client conversion table (projects/bitgesell/src/rpc/client.cpp) and RPC server named arguments mismatch!
{('gettxoutsetinfo', 2, 'use_index'), ('gettxoutsetinfo', 1, 'hash_or_height')}

How to reproduce:

Run functional test: python test/functional/rpc_help.py

Root cause:

It looks like RPC client was not updated to reflect changes in the commit

https://github.com/BitgesellOfficial/bitgesell/blame/a3cb9f76cd01fa5bb9188d45d05e5b0f8e090e6e/src/rpc/blockchain.cpp#L1103

to use coinstatsindex if available.

The RPC client in this call is missing use_index argument:

https://github.com/BitgesellOfficial/bitgesell/blame/a3cb9f76cd01fa5bb9188d45d05e5b0f8e090e6e/src/rpc/client.cpp#L145

[gitcoindev]

I had a look in the open PRs and the likely change was implemented in a big bang commit somewhere inside https://github.com/BitgesellOfficial/bitgesell/pull/49/files

[gitcoindev]

Does not fail on master after last updates.