-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can DelayedArray:::.rec_showtree
be a generic?
#119
Comments
Isn't WrapperArraySeed a no-op from a delayed op point of view? If that's the case, how about having WrapperArraySeed extend DelayedUnaryIsoOp?
Another benefit of doing this is that you no longer need to define all the trivial |
Edit: Please ignore this. Furthermore, right now you have the following class hierarchy in alabaster.matrix:
That sounds like a lot of classes! In particular I'm not sure about the need for the *ArraySeed classes when you could just do:
That is: add the I'm probably overlooking the reasons that motivated the current approach but wanted to mention this simpler approach just in case. H. |
Hmm.. yeah of course there are good reasons for having the *ArraySeed classes. My over-simplified proposal above doesn't work. Please ignore. |
Have you tried to make WrapperArraySeed a DelayedUnaryIsoOp derivative? Can we close this? |
Oh sorry, I only read your "please ignore this" message and ignored the entire thread. Just tried it out and it seems reasonable. Might even be able to get rid of |
Thanks for the update. I'll close then. Please re-open or create a new issue if you think we should discuss this further. |
For custom seeds, I would like to be able to make
showtree()
more informative. For example, I might have a seed class where one or more of the slots is anotherDelayedArray
, and I would like to show the delayed operations of the componentDelayedArray
s rather than just terminating the tree at my seed.More specifically, alabaster.matrix has a
ReloadedArray
class that could potentially store aDelayedOp
in itsseed
slot. Currently,showtree()
terminates at theReloadedArraySeed
:I would like to be able to write a
.rec_showtree()
method so that I get something like:Even better if I can just return some kind of nested list and
showtree()
handles the pretty printing.Session information
The text was updated successfully, but these errors were encountered: