Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RamEx #3700

Open
qibebt-bioinfo opened this issue Jan 6, 2025 · 5 comments
Open

RamEx #3700

qibebt-bioinfo opened this issue Jan 6, 2025 · 5 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@qibebt-bioinfo
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • [√ ] I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • [√] I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • [√] I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • [√] I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • [√] My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • [√] I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • [√] I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • [√] The 'devel' branch for new packages and features.
  • [√] The stable 'release' branch, made available every six
    months, for bug fixes.
  • [√] Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @qibebt-bioinfo

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: RamEx
Type: Package
Title: Ramanome Explorer is a R package for comprehensive and efficient analysis and comparison of ramanomes.
Version: 0.99.0
Authors@R: 
    c(
        person("Yanmei", "Zhang", role = c("aut"), comment = "Co-Author"),
        person("Gongchao", "Jing", email = "[email protected]", role = c("aut", "cre"))
    )
Description: By providing simple-to-use modules for computational tasks that otherwise would require substantial programming experience and algorithmic skills, RamEx should greatly facilitate the computational mining of ramanomes.More complete information about how to use RamEx can be found in the [github](https://github.com/qibebt-bioinfo/RamEx), but here you'll find a brief overview of the function and examples to mining of ramanomes:
License: GPL
Encoding: UTF-8
RoxygenNote: 7.3.2
Depends: R (>= 3.0), RColorBrewer, Rcpp, circlize
Imports:
   MASS, MLmetrics, Matrix, NMF, parallel, Rtsne, cowplot, data.table, dbscan, disprofas, doParallel, dplyr, e1071, fastICA, foreach, ggforce, ggplot2, ggthemes, grDevices, graphics, hyperSpec, ica, igraph, mdatools, methods, pheatmap, irlba, prospectr, purrr, randomForest, rlist, scales, stats, stringr, utils, uwot, vegan, Cairo, Hmisc, proxy, reshape2, ggtext, mclust, RcppAnnoy, ade4, magrittr, corr2D
Suggests:
    testthat,knitr, RcppParallel, Rcpp, gpuR
biocViews: Visualization, Clustering, Software
Config/testthat/edition: 3
VignetteBuilder: knitr
NeedsCompilation: no
Packaged: 2024-12-11

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jan 6, 2025
@qibebt-bioinfo
Copy link
Author

Hi, following up to make sure this doesn't get lost.

Best,
Qibebt

@lshep
Copy link
Contributor

lshep commented Jan 10, 2025

We normally process packages within 1-2 weeks. I will likely be looking at this today or next week mon/tue.

@lshep
Copy link
Contributor

lshep commented Jan 14, 2025

Please also provide an inst/scripts directory that describes how the data
in inst/extdata was generated. It can be code, pseudo-code, or text but
should minimally list any source or licensing information.

Please have a package level man page so when a naive user does ?RamEx there is
information on how to get started with the package.

It would be good to increase testing coverage.

The vignette is currently not rendering properly. Please see when you install
and do vignette("RamEx")

The vignette should be expanded. It is very minimal. Currently on quick glance,
I cannot understand how I would generate a RamEx_data object to be used in your
shown functions.

Is this to be solely used with raw data from instrumentation? Is there a way to integrate with common Bioconductor classes

@lshep lshep added the 3e. pending pre-review changes review has indicated blocking concern that needs attention label Jan 14, 2025
@qibebt-bioinfo
Copy link
Author

@lshep
Dear lshep,
Thank you for taking the time to review the RamEx package, and I truly appreciate the feedback you provided. I have made the following modifications and updates based on your suggestions:

  1. Added the RamEx-package.Rd file to implement the ??RamEx functionality;
  2. Added the RamEx_data.Rd file to describe the data;
  3. Increased testing coverage in testthat-main-function.R;
  4. Expanded the vignette in the RamEx.Rmd file.
    Thank you very much for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants