From 47b5aebc3d02ddaa5f02c3f6cf2615781e6e9830 Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Sun, 8 Dec 2024 07:05:19 -0800 Subject: [PATCH 1/8] chore: remove Python 3.8 support --- .github/workflows/build-docs.yml | 8 ++++---- .github/workflows/publish-pypi.yml | 2 +- .github/workflows/run-tests.yml | 6 +++--- CHANGELOG.md | 5 +++++ setup.cfg | 2 +- 5 files changed, 14 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml index 1381761..de1c66b 100644 --- a/.github/workflows/build-docs.yml +++ b/.github/workflows/build-docs.yml @@ -11,14 +11,14 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: true - - name: Set up Python 3.9 - uses: actions/setup-python@v2 + - name: Set up Python 3.11 + uses: actions/setup-python@v5 with: - python-version: 3.9 + python-version: 3.11 cache: 'pip' - name: Install Python dependencies diff --git a/.github/workflows/publish-pypi.yml b/.github/workflows/publish-pypi.yml index abc9222..84bcd6b 100644 --- a/.github/workflows/publish-pypi.yml +++ b/.github/workflows/publish-pypi.yml @@ -116,7 +116,7 @@ jobs: name: Build source distribution runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: true diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5c8d6b1..d8596af 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -12,16 +12,16 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ] + python-version: [ '3.9', '3.10', '3.11', '3.12', '3.13' ] name: Python ${{ matrix.python-version }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: true - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} cache: 'pip' diff --git a/CHANGELOG.md b/CHANGELOG.md index 425eb42..0d8ac77 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## Version 0.6.0 + +- chore: Remove Python 3.8 (EOL). +- precommit: Replace docformatter with ruff's formatter. + ## Version 0.5.1 - Added parser for delayed sparse objects backed by H5 diff --git a/setup.cfg b/setup.cfg index ce2bd72..306d4af 100644 --- a/setup.cfg +++ b/setup.cfg @@ -41,7 +41,7 @@ package_dir = =src # Require a min/specific Python version (comma-separated conditions) -python_requires = >=3.8 +python_requires = >=3.9 # Add here dependencies of your project (line-separated), e.g. requests>=2.2,<3.0. # Version specifiers like >=2.2,<3.0 avoid problems due to API changes in From 6e50472e673a1af48ae6c1508b3c72be8d9e795a Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Sun, 8 Dec 2024 07:22:17 -0800 Subject: [PATCH 2/8] catchup docs --- docs/conf.py | 1 + docs/requirements.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/conf.py b/docs/conf.py index 03c8fa0..75b31cf 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -72,6 +72,7 @@ "sphinx.ext.ifconfig", "sphinx.ext.mathjax", "sphinx.ext.napoleon", + "sphinx_autodoc_typehints", ] # Add any paths that contain templates here, relative to this directory. diff --git a/docs/requirements.txt b/docs/requirements.txt index 6d65a9b..daecbf1 100644 --- a/docs/requirements.txt +++ b/docs/requirements.txt @@ -5,3 +5,4 @@ furo # sphinx_rtd_theme myst-parser[linkify] sphinx>=3.2.1 +sphinx-autodoc-typehints From e45bbd3a0fca5b5bbd41b84509359c71e3eea6fa Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Sun, 8 Dec 2024 07:52:47 -0800 Subject: [PATCH 3/8] rename actions --- .github/workflows/{publish-pypi.yml => pypi-publish.yml} | 0 .github/workflows/{run-tests.yml => pypi-test.yml} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{publish-pypi.yml => pypi-publish.yml} (100%) rename .github/workflows/{run-tests.yml => pypi-test.yml} (100%) diff --git a/.github/workflows/publish-pypi.yml b/.github/workflows/pypi-publish.yml similarity index 100% rename from .github/workflows/publish-pypi.yml rename to .github/workflows/pypi-publish.yml diff --git a/.github/workflows/run-tests.yml b/.github/workflows/pypi-test.yml similarity index 100% rename from .github/workflows/run-tests.yml rename to .github/workflows/pypi-test.yml From fad024635a1aa74edd65c2922c59f0dae055a11e Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Sun, 8 Dec 2024 08:47:29 -0800 Subject: [PATCH 4/8] update the publish action --- .github/workflows/pypi-publish.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index 84bcd6b..bdbd3d9 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -11,13 +11,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build wheels uses: pypa/cibuildwheel@v2.16.2 env: CIBW_ARCHS: x86_64 - CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" CIBW_MANYLINUX_X86_64_IMAGE: ghcr.io/artifactdb/prebuilt-hdf5/manylinux_x86_64:0.0.4 CIBW_MUSLLINUX_X86_64_IMAGE: ghcr.io/artifactdb/prebuilt-hdf5/musllinux_x86_64:0.0.4 CIBW_SKIP: pp* @@ -31,7 +31,7 @@ jobs: runs-on: macos-13 steps: - name: Check out repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Grab prebuilt dependencies run: | @@ -42,7 +42,7 @@ jobs: uses: pypa/cibuildwheel@v2.16.2 env: CIBW_ARCHS: x86_64 - CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=$(pwd)/installed -DCMAKE_OSX_ARCHITECTURES=x86_64\"" CIBW_BUILD_VERBOSITY: 3 CIBW_SKIP: pp* @@ -57,7 +57,7 @@ jobs: runs-on: macos-13 steps: - name: Check out repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Grab prebuilt dependencies run: | @@ -68,7 +68,7 @@ jobs: uses: pypa/cibuildwheel@v2.16.2 env: CIBW_ARCHS: arm64 - CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=$(pwd)/installed -DCMAKE_OSX_ARCHITECTURES=arm64\"" CIBW_BUILD_VERBOSITY: 3 MACOSX_DEPLOYMENT_TARGET: 13.0 @@ -82,7 +82,7 @@ jobs: # runs-on: windows-2019 # steps: # - name: Check out repository -# uses: actions/checkout@v3 +# uses: actions/checkout@v4 # # - name: Grab prebuilt dependencies # run: | @@ -100,7 +100,7 @@ jobs: # uses: pypa/cibuildwheel@v2.16.2 # env: # CIBW_ARCHS: AMD64 -# CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8" +# CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" # CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}\" VERBOSE=1" # CIBW_BEFORE_BUILD_WINDOWS: "pip install delvewheel" # CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: "delvewheel repair -w {dest_dir} {wheel}" From 1ab2fecc527ee27d936470402590b6377b14bc14 Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Mon, 9 Dec 2024 10:49:43 -0800 Subject: [PATCH 5/8] Update github actions --- .github/workflows/build-docs.yml | 9 +++--- .github/workflows/pypi-publish.yml | 52 +++++++++++++++++------------- .github/workflows/pypi-test.yml | 29 ++++------------- 3 files changed, 40 insertions(+), 50 deletions(-) diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml index de1c66b..8665c4a 100644 --- a/.github/workflows/build-docs.yml +++ b/.github/workflows/build-docs.yml @@ -12,13 +12,11 @@ jobs: steps: - uses: actions/checkout@v4 - with: - submodules: true - - name: Set up Python 3.11 + - name: Set up Python 3.12 uses: actions/setup-python@v5 with: - python-version: 3.11 + python-version: 3.12 cache: 'pip' - name: Install Python dependencies @@ -34,7 +32,8 @@ jobs: touch ./docs/_build/html/.nojekyll - name: GH Pages Deployment - uses: JamesIves/github-pages-deploy-action@4.1.3 + if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/') + uses: JamesIves/github-pages-deploy-action@v4 with: branch: gh-pages # The branch the action should deploy to. folder: ./docs/_build/html diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index bdbd3d9..93886d0 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -4,6 +4,7 @@ on: push: tags: - "*" + pull_request: jobs: build_linux_x86_64: @@ -14,7 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Build wheels - uses: pypa/cibuildwheel@v2.16.2 + uses: pypa/cibuildwheel@v2.22.0 env: CIBW_ARCHS: x86_64 CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" @@ -22,13 +23,17 @@ jobs: CIBW_MUSLLINUX_X86_64_IMAGE: ghcr.io/artifactdb/prebuilt-hdf5/musllinux_x86_64:0.0.4 CIBW_SKIP: pp* - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: + name: cibw-wheels-linux-x86_64 path: ./wheelhouse/*.whl build_macosx_x86_64: - name: Build wheels for macosx x86_64 - runs-on: macos-13 + name: Build wheels on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [macos-13, macos-14] steps: - name: Check out repository uses: actions/checkout@v4 @@ -39,7 +44,7 @@ jobs: tar -xvf bundle.tar.gz - name: Build wheels - uses: pypa/cibuildwheel@v2.16.2 + uses: pypa/cibuildwheel@v2.22.0 env: CIBW_ARCHS: x86_64 CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" @@ -48,13 +53,17 @@ jobs: CIBW_SKIP: pp* MACOSX_DEPLOYMENT_TARGET: 11.7 - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: + name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}-x84_64 path: ./wheelhouse/*.whl build_macosx_arm64: - name: Build wheels for macosx arm64 - runs-on: macos-13 + name: Build wheels on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [macos-13, macos-14] steps: - name: Check out repository uses: actions/checkout@v4 @@ -65,7 +74,7 @@ jobs: tar -xvf bundle.tar.gz - name: Build wheels - uses: pypa/cibuildwheel@v2.16.2 + uses: pypa/cibuildwheel@v2.22.0 env: CIBW_ARCHS: arm64 CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" @@ -73,8 +82,9 @@ jobs: CIBW_BUILD_VERBOSITY: 3 MACOSX_DEPLOYMENT_TARGET: 13.0 - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: + name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}-arm64 path: ./wheelhouse/*.whl # build_windows_x86_64: @@ -97,7 +107,7 @@ jobs: # shell: powershell # # - name: Build wheels -# uses: pypa/cibuildwheel@v2.16.2 +# uses: pypa/cibuildwheel@v2.22.0 # env: # CIBW_ARCHS: AMD64 # CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" @@ -108,23 +118,22 @@ jobs: # CIBW_TEST_COMMAND: "pytest {package}/tests" # CIBW_BUILD_VERBOSITY: 3 - - uses: actions/upload-artifact@v3 - with: - path: ./wheelhouse/*.whl + # - uses: actions/upload-artifact@v3 + # with: + # path: ./wheelhouse/*.whl build_sdist: name: Build source distribution runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - submodules: true - name: Build sdist run: pipx run build --sdist - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: + name: cibw-sdist path: dist/*.tar.gz upload_pypi: @@ -133,14 +142,13 @@ jobs: # upload to PyPI on every tag starting with 'v' if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: - # unpacks default artifact into dist/ - # if `name: artifact` is omitted, the action will create extra parent dir - name: artifact + pattern: cibw-* path: dist + merge-multiple: true - - uses: pypa/gh-action-pypi-publish@v1.8.3 + - uses: pypa/gh-action-pypi-publish@v1.12.2 with: user: __token__ password: ${{ secrets.PYPI_PASSWORD }} diff --git a/.github/workflows/pypi-test.yml b/.github/workflows/pypi-test.yml index d8596af..f7c83ea 100644 --- a/.github/workflows/pypi-test.yml +++ b/.github/workflows/pypi-test.yml @@ -1,14 +1,13 @@ -name: Run unit tests +name: Test the library on: push: - branches: [ master ] + branches: + - master pull_request: - branches: [ master ] jobs: test: - runs-on: ubuntu-latest strategy: matrix: @@ -20,32 +19,16 @@ jobs: with: submodules: true - - name: Set up Python ${{ matrix.python-version }} + - name: Setup Python uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} cache: 'pip' - - name: Install Python dependencies - run: | - python -m pip install --upgrade pip setuptools - DEPENDENCIES=$(python -c 'from setuptools.config.setupcfg import read_configuration as c; a = c("setup.cfg"); print(" ".join(a["options"]["install_requires"][1:] + a["options"]["extras_require"]["testing"][1:]))') - pip install ${DEPENDENCIES} pybind11 + - name: Get latest CMake + uses: lukka/get-cmake@latest - # We do proper tests if we're on the master branch, or if we're creating a new release. - name: Test with tox - if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/') run: | pip install tox tox - - # Otherwise we do some cached builds and tests for faster merging of PRs. - - name: Set up ccache - if: github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags') - uses: hendrikmuhs/ccache-action@v1.2 - - - name: Quickly build and test - if: github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags') - run: | - CC="ccache gcc" python setup.py install - pytest From 9c3817e2ef0d56889435a4849f743b24d9729312 Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Mon, 9 Dec 2024 11:20:56 -0800 Subject: [PATCH 6/8] does not need prebuilt hdf5 --- .github/workflows/pypi-publish.yml | 114 +++-------------------------- 1 file changed, 11 insertions(+), 103 deletions(-) diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index 93886d0..1fb8b5b 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -4,124 +4,34 @@ on: push: tags: - "*" - pull_request: jobs: - build_linux_x86_64: - name: Build wheels for linux x86_64 - runs-on: ubuntu-latest - steps: - - name: Check out repository - uses: actions/checkout@v4 - - - name: Build wheels - uses: pypa/cibuildwheel@v2.22.0 - env: - CIBW_ARCHS: x86_64 - CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" - CIBW_MANYLINUX_X86_64_IMAGE: ghcr.io/artifactdb/prebuilt-hdf5/manylinux_x86_64:0.0.4 - CIBW_MUSLLINUX_X86_64_IMAGE: ghcr.io/artifactdb/prebuilt-hdf5/musllinux_x86_64:0.0.4 - CIBW_SKIP: pp* - - - uses: actions/upload-artifact@v4 - with: - name: cibw-wheels-linux-x86_64 - path: ./wheelhouse/*.whl - - build_macosx_x86_64: + build_wheels: name: Build wheels on ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: matrix: - os: [macos-13, macos-14] - steps: - - name: Check out repository - uses: actions/checkout@v4 + # macos-13 is an intel runner, higher macos's are apple silicon + # At some point, maybe get this to work on windows-latest + os: [ubuntu-latest, macos-13, macos-latest] - - name: Grab prebuilt dependencies - run: | - curl -L https://github.com/ArtifactDB/prebuilt-hdf5/releases/download/0.0.4/macosx_x86_64.tar.gz > bundle.tar.gz - tar -xvf bundle.tar.gz - - - name: Build wheels - uses: pypa/cibuildwheel@v2.22.0 - env: - CIBW_ARCHS: x86_64 - CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" - CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=$(pwd)/installed -DCMAKE_OSX_ARCHITECTURES=x86_64\"" - CIBW_BUILD_VERBOSITY: 3 - CIBW_SKIP: pp* - MACOSX_DEPLOYMENT_TARGET: 11.7 - - - uses: actions/upload-artifact@v4 - with: - name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}-x84_64 - path: ./wheelhouse/*.whl - - build_macosx_arm64: - name: Build wheels on ${{ matrix.os }} - runs-on: ${{ matrix.os }} - strategy: - matrix: - os: [macos-13, macos-14] steps: - - name: Check out repository - uses: actions/checkout@v4 - - - name: Grab prebuilt dependencies - run: | - curl -L https://github.com/ArtifactDB/prebuilt-hdf5/releases/download/0.0.4-manual/macosx_arm64.tar.gz > bundle.tar.gz - tar -xvf bundle.tar.gz + - uses: actions/checkout@v4 + with: + submodules: true - name: Build wheels uses: pypa/cibuildwheel@v2.22.0 env: - CIBW_ARCHS: arm64 + CIBW_ARCHS_LINUX: x86_64 # remove this later so we build for all linux archs CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" - CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=$(pwd)/installed -DCMAKE_OSX_ARCHITECTURES=arm64\"" - CIBW_BUILD_VERBOSITY: 3 - MACOSX_DEPLOYMENT_TARGET: 13.0 + CIBW_SKIP: pp* - uses: actions/upload-artifact@v4 with: - name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}-arm64 + name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }} path: ./wheelhouse/*.whl -# build_windows_x86_64: -# name: Build wheels for windows x86_64 -# runs-on: windows-2019 -# steps: -# - name: Check out repository -# uses: actions/checkout@v4 -# -# - name: Grab prebuilt dependencies -# run: | -# curl -L https://github.com/ArtifactDB/prebuilt-hdf5/releases/download/0.0.4/windows_x86_64.tar.gz > bundle.tar.gz -# tar -xvf bundle.tar.gz -# shell: bash -# -# - name: Store path -# run: | -# $wd = pwd -# echo "INSTALL_DIR=$wd\\installed" >> $env:GITHUB_ENV -# shell: powershell -# -# - name: Build wheels -# uses: pypa/cibuildwheel@v2.22.0 -# env: -# CIBW_ARCHS: AMD64 -# CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9" -# CIBW_ENVIRONMENT: "MORE_CMAKE_OPTIONS=\"-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}\" VERBOSE=1" -# CIBW_BEFORE_BUILD_WINDOWS: "pip install delvewheel" -# CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: "delvewheel repair -w {dest_dir} {wheel}" -# CIBW_TEST_EXTRAS: "testing" -# CIBW_TEST_COMMAND: "pytest {package}/tests" -# CIBW_BUILD_VERBOSITY: 3 - - # - uses: actions/upload-artifact@v3 - # with: - # path: ./wheelhouse/*.whl - build_sdist: name: Build source distribution runs-on: ubuntu-latest @@ -137,10 +47,8 @@ jobs: path: dist/*.tar.gz upload_pypi: - needs: [build_linux_x86_64, build_macosx_x86_64, build_macosx_arm64, build_sdist] + needs: [build_wheels, build_sdist] runs-on: ubuntu-latest - # upload to PyPI on every tag starting with 'v' - if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') steps: - uses: actions/download-artifact@v4 with: From a4247c79313fdd1476d34e9710a330778862fc2f Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Mon, 9 Dec 2024 11:23:41 -0800 Subject: [PATCH 7/8] add pr to test cibuildwheel workflow --- .github/workflows/pypi-publish.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index 1fb8b5b..bf0773c 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -4,6 +4,7 @@ on: push: tags: - "*" + pull_request: jobs: build_wheels: @@ -49,6 +50,7 @@ jobs: upload_pypi: needs: [build_wheels, build_sdist] runs-on: ubuntu-latest + if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') steps: - uses: actions/download-artifact@v4 with: From 528972496289bbb3bdc83eb21b1ec6838739d5cf Mon Sep 17 00:00:00 2001 From: Jayaram Kancherla Date: Mon, 9 Dec 2024 11:34:16 -0800 Subject: [PATCH 8/8] remove extra checks --- .github/workflows/pypi-publish.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index bf0773c..1fb8b5b 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -4,7 +4,6 @@ on: push: tags: - "*" - pull_request: jobs: build_wheels: @@ -50,7 +49,6 @@ jobs: upload_pypi: needs: [build_wheels, build_sdist] runs-on: ubuntu-latest - if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') steps: - uses: actions/download-artifact@v4 with: