Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandas is not quite optional as to_pandas() has DataFrame as a type hint #39

Closed
LTLA opened this issue Sep 22, 2023 · 1 comment · Fixed by #40
Closed

pandas is not quite optional as to_pandas() has DataFrame as a type hint #39

LTLA opened this issue Sep 22, 2023 · 1 comment · Fixed by #40

Comments

@LTLA
Copy link
Member

LTLA commented Sep 22, 2023

BiocFrame/src/biocframe/BiocFrame.py

Line 652 in daca714

def to_pandas(self) -> DataFrame:

This blows up CI that doesn't also install pandas, e.g., https://github.com/ArtifactDB/dolomite-base/actions/runs/6270387862/job/17028263635.

Probably just kill the type hint... what else could a user expect from a to_pandas() method, anyway?
@jkanche
Copy link
Member

jkanche commented Sep 22, 2023

guess that was stupid, but it was suggested by someone, let me fix that

@jkanche jkanche mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove pandas imports BiocPy/BiocFrame
2 participants
@jkanche @LTLA