Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bionomia badges to collections #507

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add bionomia badges to collections #507

merged 1 commit into from
Jun 20, 2023

Conversation

mandrewj
Copy link
Member

@mandrewj mandrewj commented Jun 15, 2023

Pull Request Checklist:

  • Features and backlog bugs should be merged into the Development branch, NOT master
  • Hotfixes should be merged into both the Development and master branches (at the same time).
  • All new text is preferrably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place

Thanks for contributing and keeping it clean!

Copy link
Member

@egbot egbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Like that you are using the CURLOPT_NOBODY option.

@mandrewj mandrewj merged commit dea363b into Development Jun 20, 2023
@mandrewj mandrewj deleted the Bionomia-badges branch June 20, 2023 22:07
@dshorthouse
Copy link

Looks good. Like that you are using the CURLOPT_NOBODY option.

That does the equivalent of a HEAD request, right? Not sure the Sinatra app for Bionomia would respond to it in addition to a GET request for the svg badge, but will investigate.

egbot added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants