Lang Tags for collections misc institutioneditor.php #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamisaZaman
changed the title
themerekat
approved these changes
Apr 24, 2024
| </div> | ||
| <div class="editdiv" style="display:<?php echo $eMode?'none':'block'; ?>;"> | ||
| <?php echo $instArr['institutioncode']; ?> | ||
| </div> | ||
| <div class="editdiv" style="display:<?php echo $eMode?'block':'none'; ?>;"> | ||
| <input name="institutioncode" type="text" value="<?php echo $instArr['institutioncode']; ?>" /> | ||
| <input name="getgrscicoll" type="button" value="Update from GrSciColl" onClick="grscicoll('insteditform')"/> | ||
| <button name="getgrscicoll" type="button" value="Update from GrSciColl" onClick="grscicoll('insteditform')"><?php echo $LANG['UPDATE_GRSCICOLL']; ?></button> |
There was a problem hiding this comment.
@Atticus29 , should this be type=submit now, or is it ok as type=button?
RamisaZaman
deleted the
Internationalize-for-collections-misc-institutioneditor.php
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
Pre-Approval
Developmentbranch, NOTmasterPost-Approval
Developmentbranch, remember to use the squash & merge optionDevelopmentbranch into the master branch, remember to use the merge optionmasterbranch, a subsequent PR frommasterintoDevelopmentshould be made merge option (i.e., no squash).Developmentbranch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopmentbranch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!