-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating all objects without prototypes breaks public API #55
Comments
See also indexzero/nconf#314 |
@nerdbeere You're right - sorry about this. I didn't consider it until after it was published to npm, and I sort of waffled on whether or not it would be a breaking change. I'm thinking of reverting this change, publishing a new 2.x release, and then re-committing the fix in a new 3.x line. Do you have any other ideas? |
@BinaryMuse Sounds like a good strategy to me. |
This change is reverted in |
Hi @BinaryMuse
one could argue that the changes introduced in 7f84702 are changing the public api of your module and following semver should lead to a new major version instead of the patch version you published.
I use nconf in combination with your package which unfortunately relies on
Object.hasOwnProperty
which no longer works.The text was updated successfully, but these errors were encountered: