Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code actions not working #1400

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Fix code actions not working #1400

merged 3 commits into from
Nov 29, 2021

Conversation

bpringe
Copy link
Member

@bpringe bpringe commented Nov 29, 2021

What has Changed?

  • workspace/executeCommand is now called manually by Calva in the resolveCodeAction LSP middleware function, since it does not seem to be called automatically by the vscode-languageclient library (version 7.0.0) as it was in version 6.1.3 of that lib.

Version 7.0.0 uses version 3.16 of the protocol, which introduced the codeAction/resolve request. The response for that request includes the command to run and the arguments to pass.

Fixes #1373

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

Copy link
Contributor

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bpringe bpringe merged commit 7a4d8da into dev Nov 29, 2021
@bpringe bpringe deleted the fix_code_actions_not_working branch November 29, 2021 00:52
bpringe added a commit that referenced this pull request Dec 14, 2021
bpringe added a commit that referenced this pull request Dec 14, 2021
…dits_files_while_in_live_share

Revert #1400. Make Calva stop editing the current file while in Live Share.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants