Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
workspace/executeCommand
is now called manually by Calva in theresolveCodeAction
LSP middleware function, since it does not seem to be called automatically by the vscode-languageclient library (version 7.0.0) as it was in version 6.1.3 of that lib.Version 7.0.0 uses version 3.16 of the protocol, which introduced the
codeAction/resolve
request. The response for that request includes the command to run and the arguments to pass.Fixes #1373
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.ci/circleci: build
test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.Ping @PEZ, @bpringe