Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] The command for opening a Clojure(Script) REPL window does not work #193

Closed
PEZ opened this issue May 29, 2019 · 1 comment
Closed
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@PEZ
Copy link
Collaborator

PEZ commented May 29, 2019

Repro:

  1. Jack in or connect.
  2. Wait for the REPL window to open
  3. Close the REPL tab
  4. Issue the command Calva: Open a Clojure REPL

Expected: The REPL window should open again.

Actual: Nothing happens.

I've tracked it down to the that the clone nRepl message resulting from the command. We seem to fail to pick up the response:

https://github.com/BetterThanTomorrow/calva/blob/dev/calva/nrepl/index.ts#L145

We do succeed with this at the actual connect/jack-in, so maybe it is something wrong with the session we try to clone here.

@PEZ PEZ added bug Something isn't working help wanted Extra attention is needed labels May 29, 2019
@PEZ
Copy link
Collaborator Author

PEZ commented May 29, 2019

Now I think it is that we do not maintain the client.sessions object correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant