-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better integration with live share: push evaluation decorations #182
Comments
This is a very interesting thing. We're using Calva with Live Share right now, and to get pair programming to work that way, we have to share screen with Hangouts at the same in order to see the REPL output (we're using the output window more that the editor "decorations). The way we work is that we're pair-programming or mob-programming and collaboratively editing with Live Share, but the biggest problems are 1) not being able to see the REPL of the common session, and 2) Not being able to evaluate in the shared session (read: the REPL of the one who created the session.) Is there any hope that this could work over Live Share, at least on the level of "Shared Terminals" to see the output, and even better if the eval could be done on the session initiators machine? |
Hi @niclasnilsson! For now what Calva can offer is a feature that @teves-castro added: Evaluate current form and append as comment (exact wording eludes me right now), the default shortcut is ctrl+alt+c, c. Regardless of Live Share or not I recommend taking the advice from Stuart Halloway of getting into the habit of using the REPL inside the editor, instead of at the REPL prompt. Calva has a special treatment of |
Yes, about where the evaluation is done. I think you can achieve that by the session initiator opening the REPL port over Live Share, and the participants connecting Calva to that port. Not sure about this though, it was a while since I Live Shared anything... |
Agree fully. We never type anything in the REPL, just sending forms to it, but in our case, due to the data we're manipulating, it's often easier see the result in the REPL output. Pretty printing in different ways, print-table and stuff can come in pretty (pun intended) handy at times. |
And thanks, I'll take another look and see if we can open the REPL port to Live Share. |
I just released Calva v2.0.40. It offers a hover for the evaluated form which displays the result. Pretty printed, if that was what you ordered when evaluating. I don' t know if this hover transfers well over Live Share, but I am curious, so please test it and let me know. |
@niclasnilsson A friend and I shared a REPL with live share by me (the initiator) sharing my repl port through live share, as @PEZ was saying. I don't remember the exact details, but he could define a function on his end, and I could use it on my end. |
How much of this is still relevant? Maybe @svdo knows? |
I think it can probably be closed. If I encounter issues like this coming week (when I'll be testing live share support) I'll open new tickets. |
Closing this now. Let's reopen this or open separate issues if needed. |
@svdo Question: Are eval decorations shown in live share for all participants? If not, is there an easy way to broadcast the eval results besides using the "eval to comment" command? |
I only know that the decorations only work locally. Personally that's the way I like it, but YMMV... |
Currently when evaluating a form during a live share session the resulting decorations are not being shown on the other participants editors.
By using the VS Live Share Extension API it might be possible to create a kind of a chat service amongst live share participants to push those evaluations to every other participant.
The text was updated successfully, but these errors were encountered: