Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deps.edn and Leiningen + shadow-cljs project support #1591

Closed
PEZ opened this issue Mar 11, 2022 · 1 comment
Closed

Improve deps.edn and Leiningen + shadow-cljs project support #1591

PEZ opened this issue Mar 11, 2022 · 1 comment
Labels
connect documentation Better documentation needed. jack-in ux User experience related

Comments

@PEZ
Copy link
Collaborator

PEZ commented Mar 11, 2022

The connect sequences involving deps.edn or Leiningen + shadow-cljs often cause troubles for people. I think it is due to that shadow-cljs dependencies are assumed to be present.

Many of these projects are configured so that shadow-cljs uses deps.edn or Leiningen for dependencies and then it is a better Calva workflow to start them that way. I think we can improve the documentation to help with this a bit. But we should also look at how the Jack-in process can guide better. And when the dependencies are not met, we need better error messaging (or inject the dependency, which I am a bit hesitant to do, because we used to inject Figwheel dependencies and that caused troubles in other ways).

Two related issues:

Here's a thread illustrating where the current state of affairs cause confusion: https://clojureverse.org/t/understanding-jack-in-in-calva/

@PEZ PEZ added documentation Better documentation needed. jack-in connect ux User experience related labels Mar 11, 2022
@PEZ
Copy link
Collaborator Author

PEZ commented Mar 14, 2023

I think this is mostly taken care of by now.

@PEZ PEZ closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect documentation Better documentation needed. jack-in ux User experience related
Projects
None yet
Development

No branches or pull requests

1 participant