Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show eval in repl option #1465

Closed
Cyrik opened this issue Jan 11, 2022 · 2 comments
Closed

[Feature Request] Show eval in repl option #1465

Cyrik opened this issue Jan 11, 2022 · 2 comments

Comments

@Cyrik
Copy link
Member

Cyrik commented Jan 11, 2022

Currently eval commands like "Evaluate current form" send the form to the repl silently and then print the result. Custom repl commands show the forms in the repl first and then print the result.

These should behave the same way and an option should be provided to toggle the behavior.

The initial idea of equal behavior came from @PEZ but I'm happy to work on this since I'm playing with the command code anyway.
Any feedback on the design would be appreciated.

@PEZ
Copy link
Collaborator

PEZ commented Jan 12, 2022

We can consider to model this similar to how we treat pretty print toggling. It's a setting, but has special support in that it can be toggled via the status bar and via a keyboard shortcut.

@Cyrik
Copy link
Member Author

Cyrik commented Jan 13, 2022

I like the hotkey, but at least for me, the status bar is already filling up. I'm not sure this is important enough to have a place on it. But I guess it's fine if it's just an icon instead of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants