Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaultConfig is failing to normalise address when loading from environment #200

Open
rtib opened this issue Dec 20, 2019 · 1 comment · May be fixed by #201
Open

VaultConfig is failing to normalise address when loading from environment #200

rtib opened this issue Dec 20, 2019 · 1 comment · May be fixed by #201

Comments

@rtib
Copy link

rtib commented Dec 20, 2019 •
edited
Loading

When setting up an address having a trailing slash (/), the driver will work fine since VaultConfig#address will normalise the address. Providing the same address via environment variable VAULT_ADDR and let the driver load it, the VaultConfig#build method is bypassing the address normalisation, ending up in a broken config.
@rtib rtib linked a pull request Dec 20, 2019 that will close this issue
Open
@juggernaut0
Copy link

Just got bit by this, would be nice to have consistent behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

normalize address when load from env rtib/vault-java-driver
2 participants
@rtib @juggernaut0