-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: CSS supercharge for Google-Bot and robustness #1478
Labels
Comments
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
migbash
added a commit
that referenced
this issue
Aug 9, 2023
* issue: #1278 * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; dynamic svg import; * issue: #1278; cont; dynamic home-page comp import; * issue: #1278; cont; dynamic home-page comp import; * chore: Makefile; package.json; update; * doc: vite.config.ts; * issue: #1478; Test Header; logic; mobile-first; * issue: #1478; Test CSS-Js variable communication; * issue: #1478; vite.config.ts update; * update: #1478; all-css-chunk.css; * Revert to e92886 -> home/Layout.svelte; * update: #1478; all-css-chunk.css; * update: #1278; empty preloadStrategy; * update: #1278; preloadStrategy -> preload-js; * update: #1278; preloadStrategy -> preload-js; * upd: #1278; preloadStrategy -> preload-js; cont; * upd: #1278; preloadStrategy -> preload-mjs; cont; * upd: #1278; build::manualChunks homepage single; * upd: #1278; build::manualChunks cont; * upd: #1278; preloadStrategy -> modulepreload; * upd: #1278; build::manualChunks cont; cssJsChunk; * upd: #1278; build::manualChunks cont; * upd: #1278; src/app.html hardcode all CSS; * revert to ab873 -> vite.config.ts; * doc: svelte.config.js; vite.config.js; * update: +layout.server.ts revamp; * update: +layout.svelte revamp; * del: +layout.ts in favour of .server.ts; * doc: [[lang=lang]]/+page.ts; * chore: remove firebase/common.ts; * feat: sessionStore add deviceType; * chore: app.html clean; * chore: utils/debug.ts clean; * chore: utils/dates.ts clean; * chore: utils/platform-functions.ts clean; * chore: utils/languages.ts clean; * chore: api/utils.ts clean; * chore: u/[view]/[lang=lang] page.server.ts; * update: all homepage widgets entry .svelte; * update: homepage main Layout.svelte; * chore: update debug logs on few components; * issue: #1478; vite.config.ts update; * update: src/hooks.server.ts; * update: Auth_Widget.svelte; * pkg: ua-parser-js; mansory-layout; device-dete-js; * chore: svelte.config.ts; * issue: #1478; vite.config.ts update; compression; * update: +layout.svelte add SplashScreen; * update: Makefile; * update: +layout.svelte revert SplashScreen; * update: +layout.server.ts add setHeaders(..); * update: svelte.config.ts; add pre-compress; * update: Makefile; * update: Makefile; * issue: #1478; vite.config.ts update; minfication; * issue: #1478; homepage widgets (some) dynamicload; * issue: #1478; homepage widgets (cont) dynamicload; * issue: #1478; single-chunk and in-head css; * chore: add analytics to app.html; * doc: svelte.config.ts; * issue: #1278; adjusting dynamic importing v6.5 * issue: #1278; home/Layout.svelte dynamic v6.5; * chore: Email-Sub; Offline-Alert; Plat-Alert v6.5; * chore: Makefile update; * chore: package.json update; * chore: translation.ts ; * chore: +layout.svelte v6.5; * chore: [[lang=lang]]/+page.svelte v6.5; * chore: [[lang=lang]]/+page.ts v6.5;
jonsnowpt
pushed a commit
that referenced
this issue
Aug 10, 2023
* chore: add vscode/snippets.code-snippets; * chore: Footer re-structure; * chore: app.css comments + clean; * update: +layout Footer re-structure; * chore: components/home/leagues-list -> v6; * chore: components/home/leagues-table -> v6; * chore: components/home/seo-block -> v6; * upd: +layout league-list; league-table; seo-block; * update: vscode/snippets.code-snippets; * update: Makefile; * update: Makefile; * update: package.json > scripts; * update: package.json > scripts; * update: package.json; * update: vscode/snippets.code-snippets; * Feature/1421/user-profile-withdraw (#1479) * feat: #1421; new Withdraw Widget-Main + Modal; * feat: #1421; new Withdraw assets; * feat: #1421; new Withdraw Widget ref +page.svelte; * chore: clean store/user-settings.ts; * doc: OpenApi adjust for Tx to DB action endpoint; * feat: #1421; new balance Firebase upd func; clean; * feat: #1421; endpoint /api/data/profile POST add; * update: app.css for global form > input; clean; * feat: #1421; add Withdraw-Widget Profile/Menu-Opt; * feat: #1421; endpoint /api/data/profile; cont; * pkg: @scores-lib ➤ 1.4.0; * issue: #1483; * pkg: ibantools 4.3.3; * pkg: @scores-lib ➤ 1.4.1; * issue: #1483; withdraw-fixes; cont; * issue: #1486; * issue: #1485; * issue: #1486; cont; * issue: #1488; * issue: #1491; * issue: #1497; #1489; #1495; * issue: #1497; cont; * issue: #1504; * issue: #1506; * issue: #1507; #1502; * issue: #1508; * issue: #1497; * issue: #1497; cont; * issue: #1497; cont; * pkg: @scores-lib ➤ 1.4.4; * issue: #1491; * pkg: @scores-lib ➤ 1.4.5; * issue: #1491; adjust show more action text; * issue: #1498; * pkg: @scores-lib ➤ 1.4.6; * issue: #1498; types update; * chore: firebase secrets; * chore: firebase secrets; * Issue/1278/pre load css js (#1510) * issue: #1278 * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; * issue: #1278; cont; dynamic svg import; * issue: #1278; cont; dynamic home-page comp import; * issue: #1278; cont; dynamic home-page comp import; * chore: Makefile; package.json; update; * doc: vite.config.ts; * issue: #1478; Test Header; logic; mobile-first; * issue: #1478; Test CSS-Js variable communication; * issue: #1478; vite.config.ts update; * update: #1478; all-css-chunk.css; * Revert to e92886 -> home/Layout.svelte; * update: #1478; all-css-chunk.css; * update: #1278; empty preloadStrategy; * update: #1278; preloadStrategy -> preload-js; * update: #1278; preloadStrategy -> preload-js; * upd: #1278; preloadStrategy -> preload-js; cont; * upd: #1278; preloadStrategy -> preload-mjs; cont; * upd: #1278; build::manualChunks homepage single; * upd: #1278; build::manualChunks cont; * upd: #1278; preloadStrategy -> modulepreload; * upd: #1278; build::manualChunks cont; cssJsChunk; * upd: #1278; build::manualChunks cont; * upd: #1278; src/app.html hardcode all CSS; * revert to ab873 -> vite.config.ts; * doc: svelte.config.js; vite.config.js; * update: +layout.server.ts revamp; * update: +layout.svelte revamp; * del: +layout.ts in favour of .server.ts; * doc: [[lang=lang]]/+page.ts; * chore: remove firebase/common.ts; * feat: sessionStore add deviceType; * chore: app.html clean; * chore: utils/debug.ts clean; * chore: utils/dates.ts clean; * chore: utils/platform-functions.ts clean; * chore: utils/languages.ts clean; * chore: api/utils.ts clean; * chore: u/[view]/[lang=lang] page.server.ts; * update: all homepage widgets entry .svelte; * update: homepage main Layout.svelte; * chore: update debug logs on few components; * issue: #1478; vite.config.ts update; * update: src/hooks.server.ts; * update: Auth_Widget.svelte; * pkg: ua-parser-js; mansory-layout; device-dete-js; * chore: svelte.config.ts; * issue: #1478; vite.config.ts update; compression; * update: +layout.svelte add SplashScreen; * update: Makefile; * update: +layout.svelte revert SplashScreen; * update: +layout.server.ts add setHeaders(..); * update: svelte.config.ts; add pre-compress; * update: Makefile; * update: Makefile; * issue: #1478; vite.config.ts update; minfication; * issue: #1478; homepage widgets (some) dynamicload; * issue: #1478; homepage widgets (cont) dynamicload; * issue: #1478; single-chunk and in-head css; * chore: add analytics to app.html; * doc: svelte.config.ts; * issue: #1278; adjusting dynamic importing v6.5 * issue: #1278; home/Layout.svelte dynamic v6.5; * chore: Email-Sub; Offline-Alert; Plat-Alert v6.5; * chore: Makefile update; * chore: package.json update; * chore: translation.ts ; * chore: +layout.svelte v6.5; * chore: [[lang=lang]]/+page.svelte v6.5; * chore: [[lang=lang]]/+page.ts v6.5; * chore: fix merge errors; * fix: adjust hardcoded CSS; * (empty commit); * fix: adjust vite.config.ts; * chore: firebase secrets; * github: workflow secrets; * github: workflow secrets;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Does a duplicate issue exist?
🤔 Is feature request related to a problem? Please describe the problem.
Google-Bot (Mobile-Friendly Test) is failing due to unknown domain restrictions, but theorised to be due to the
domain rating
. Requires a solution to get the website visibility onGoogle
and better Google Rating.This issue proposes the necessary solutions to get this issue of type
wontfix
to befixed
.In addition, it's outlined the steps, solutions, resources necessary to get this feature working.
📝 Feature Request Description
🟩 Solution
By:
Altering thebundle
process to generate a single CSS chunk from all.svelte
files, and,CSS
to take the main role of handling the page layout components show/hide logic of different deviceviewports
changes - moving it away from the currentJS
implementation.We can guarantee the valid
CSS
andstyle
is shown to the user, regardless of wether they haveJS
enabled or not, and thus solving the Google-Bot issue once and for all, asCSS
can be dumped into a single file for the entire project.📑 In detail
The implementation of the single
CSS
chunk dump for asveltekit
project has been tackled, a valid solution has been implemented, and stashed.This feature focuses on the implementation of the
CSS Supercharge
, to move away fromJs
the logic of device viewport handling and layout change. Nothing else.In this
feature
the following changes are expected:@media
queries, and its inner block code, toshow/hide
specific sections of the component/page, depending on user device viewport and device width..svelte
component, to adjust a uniqueCSS Variable
depending on user device viewport/width. For example, as illustrated below:This
change
can then be picked up by the following code logic inJS
(ifJS
is available on the browser, and page resources are correctly loaded).➕ Further context and resources (cummulative)
📚 Resources
The text was updated successfully, but these errors were encountered: