Nesting Flag builder in Flag #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And made the Flags class final, so it cannot be extended.
|
I'll look at it now. |
Flag was marked as deprecated, which may be okay, but because it caused a lot of warnings in the tests because they bypass the builder I removed the deprecation but kept the warning in the JavaDoc.
|
@Poslovitch Should be fixed now. |
|
Thanks @tastybento ! Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the flag builder to be nested in the Flag class. However, I cannot get to fix the tests.
@tastybento Can you have a look at this, please? 🙂