Added LangUtils support.

[apachezy]

I added a hook to BentoBox to support LangUtils. If I have any problems with my work, please correct me.

LangUtils can be used to localize the names of items, entities, enchants, etc.
Since the original author and NyaaCat Community are not actively updating, I'm reconstructing LangUtils.

My LangUtils project address is:
https://github.com/apachezy/LangUtils

[tastybento]

Interesting. I tried this a while ago with #1549 but it never got finished. I assume other parts of the code can use this for translations.

[BONNe]

Should we need both repositories?
What is the difference

[BONNe]

Also, I am not a keen fan of reflection. Isn't there a way how to access plugin directly without reflection?

[apachezy]

Should we need both repositories?
What is the difference

Because I was in China, there was a high delay in visiting GitHub, so I used another domestic VCS repositorie, but it seems that there was also a high delay in visiting gitee from abroad......

[tastybento]

@BONNe Do you think this is ok to merge?

[BONNe]

I do not see obvious issues with it.

However, someone will need to take care of explaining this:

    private static boolean doHook(Plugin plugin) {
        // Because there are other plugins with the same name,
        // we should check here whether it is the plugin we need.
        boolean classExists;
        try {
            Class.forName("com.meowj.langutils.lang.LanguageHelper");
            classExists = true;
        } catch (ClassNotFoundException e) {
            classExists = false;
        }

        hooked = plugin != null && plugin.isEnabled() && classExists;
        return hooked;
    }

If there are different LanguageHelper plugins, we could run into issues when people used incorrect one and complain why they do not work.

[apachezy]

Ahhhh, I accidentally clicked to close! ! !

[apachezy]

I do not see obvious issues with it.

However, someone will need to take care of explaining this:

    private static boolean doHook(Plugin plugin) {
        // Because there are other plugins with the same name,
        // we should check here whether it is the plugin we need.
        boolean classExists;
        try {
            Class.forName("com.meowj.langutils.lang.LanguageHelper");
            classExists = true;
        } catch (ClassNotFoundException e) {
            classExists = false;
        }

        hooked = plugin != null && plugin.isEnabled() && classExists;
        return hooked;
    }

If there are different LanguageHelper plugins, we could run into issues when people used incorrect one and complain why they do not work.

Sorry, my English is very bad.

This is because I have seen other plug-ins called "LangUtils" elsewhere, but their functions are completely different! Therefore, a judgment to determine whether the "class" exists is added.
I have also considered whether to increase the judging whether some methods exist.

[BONNe]

Hmm, now I am more confused than previously.

The code you added means that there is a lot of LangUtils plugins that comes from com.meowj.langutils.lang

[apachezy]

Hmm, now I am more confused than previously.

The code you added means that there is a lot of LangUtils plugins that comes from com.meowj.langutils.lang

What I mean is that the name of some plugins in Plugin.yml is "LangUtils".

Yes it is. . . . You are right to say that, the original author of LangUtils, LangUtils of the Nyaacat community, are all from com.meowj.langutils.lang.
But the LangUtils I refactored is compatible with theirs. . .

[tastybento]

We'll need to list at least one that we are compatible with in the docs. I assume the root one is this one? https://github.com/NyaaCat/LanguageUtils

Can you provide other links?

[apachezy]

We'll need to list at least one that we are compatible with in the docs. I assume the root one is this one? https://github.com/NyaaCat/LanguageUtils

Can you provide other links?

Please do not include https://github.com/NyaaCat/LanguageUtils in the document because it is not compatible with BentoBox.

Currently only https://github.com/apachezy/LangUtils is fully compatible with BentoBox, because it implements more game object name translation.

[tastybento]

I made #1705

[tastybento]

I'm good with this. If @BONNe is good, then we merge.

[BONNe]

Yes, I am good with it