Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest spigot (paper) build huge performance issue #748

Closed
Kryniowesegryderiusz opened this issue Jun 10, 2019 · 8 comments
Closed

Latest spigot (paper) build huge performance issue #748

Kryniowesegryderiusz opened this issue Jun 10, 2019 · 8 comments
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug.

Comments

@Kryniowesegryderiusz
Copy link

Kryniowesegryderiusz commented Jun 10, 2019

Description

Describe the bug

There is a huge world save performance issue on latest (76) paper build on saving:
https://timings.aikar.co/?id=2df0775b063a429e82f9b6cdbdcb51d6

Could be after 74 "Improve autosave" update

Steps to reproduce the behavior

Just use this build and have fun XD

Screenshots and videos

Expected behavior

Environment

Server

  • OS: ________
  • Java version: ________

Plugins

_______

BentoBox setup

BentoBox and Addons
10.06 18:07:07 [Server] INFO Running PAPER 1.14.2.
10.06 18:07:07 [Server] INFO BentoBox version: 1.5.0-SNAPSHOT-b1137
10.06 18:07:07 [Server] INFO Loaded Game Worlds:
10.06 18:07:07 [Server] INFO skyblock (SkyBlock): Overworld, Nether, End
10.06 18:07:07 [Server] INFO Loaded Addons:
10.06 18:07:07 [Server] INFO Biomes 1.5.0.0-SNAPSHOT-b97
10.06 18:07:07 [Server] INFO BSkyBlock 1.5.0
10.06 18:07:07 [Server] INFO Challenges 0.7.5-SNAPSHOT-#227
10.06 18:07:07 [Server] INFO Level 1.5.0-SNAPSHOT
10.06 18:07:07 [Server] INFO TeamChat ${version}
10.06 18:07:07 [Server] INFO WelcomeWarps 1.5.0-SNAPSHOT

Configuration
  • Database: YAML

Additional context

@Kryniowesegryderiusz Kryniowesegryderiusz added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Jun 10, 2019
@tastybento
Copy link
Member

Weird. We don't listen for or act on the WorldSaveEvent so I'm not sure why BentoBox is mentioned there.

@Poslovitch
Copy link
Member

Aren't we listening to this event to run a safety database saving?

@BONNe
Copy link
Member

BONNe commented Jun 10, 2019

Challenges is listening it :(

@Kryniowesegryderiusz
Copy link
Author

The fact is that bentobox is unusable on newest versions XD

@Poslovitch
Copy link
Member

Well, that's technically a Paper issue here... :/

@Kryniowesegryderiusz
Copy link
Author

I reported that to paper
PaperMC/Paper#2161

I reported it here firstly, because of BentoBox name in it.

@electronicboy
Copy link

as a note, I overlooked something while bringing a patch back to 1.14, this has been fixed on our end now!

@Poslovitch
Copy link
Member

Great. Thanks for letting us know @electronicboy 👍

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug. and removed Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug.
Projects
None yet
Development

No branches or pull requests

5 participants