players can join 2 teams even tho islands are limit to 1 per player

[yakirarage]

Expected behavior

when a player is in a active team with friend A but they wish to switch team to join from B then fried B send a team invite then the player accepts and they are now a team with friend B and not with fried A anymore or possible get a message indicating they first have to leave friend A their team

Observed/Actual behavior

when the player is in a active team with player A and then join the team of player B by invite they are still in a team with player A meaning they can use (acid gamemode in this case) /acid go to go between both islands

we have our islands limited to 1 per player we also have our islands set delete when they join a team so it is odd that using 2 different teams they can still get 2 islands

Steps/models to reproduce

1. join team of friend A
2. do not leave the team
3. let player B send a team invite
4. accept team invite of player B without leaving player A their team
5. then use / go to switch between both islands

BentoBox version

bbox version
Running PAPER 1.20.4.
(git-Paper-497 (MC: 1.20.4))
BentoBox version: 2.3.0
Database: JSON
Loaded Game Worlds:
acid (acid): Overworld
cave (cave): Overworld
oneblock (oneblock): Overworld
parkour (parkour): Overworld
skyblock (skyblock): Overworld
skygrid (skygrid): Overworld
Loaded Addons:
AcidIsland 1.19.0-SNAPSHOT-b1016 (ENABLED)
AOneBlock 1.17.0-SNAPSHOT-b400 (ENABLED)
Biomes 2.2.0-SNAPSHOT-b258 (ENABLED)
Border 4.2.2 (ENABLED)
BSkyBlock 1.18.0-SNAPSHOT-b761 (ENABLED)
CaveBlock 1.19.0-SNAPSHOT-b444 (ENABLED)
Challenges 1.3.0 (ENABLED)
FarmersDance 1.1.0-SNAPSHOT (ENABLED)
Greenhouses 1.8.0-SNAPSHOT-b370 (ENABLED)
Level 2.13.0-SNAPSHOT-b564 (ENABLED)
Limits 1.21.0 (ENABLED)
MagicCobblestoneGenerator 2.5.2-SNAPSHOT-b272 (ENABLED)
Parkour 1.3.1-SNAPSHOT-b86 (ENABLED)
SkyGrid 2.0.0-SNAPSHOT-b426 (ENABLED)
TopBlock 1.0.2-SNAPSHOT-b25 (ENABLED)
Warps 1.15.0-SNAPSHOT-b362 (ENABLED)

Plugin list

No response

Other

No response

[tastybento]

This is not actually a bug on BentoBox but is because the Game Mode Addons are not updated. The default setting for allowing team members to join more than one team is disallowed in BentoBox by default, but because the addons are built against an older version of BentoBox than 2.3.0, they default to false, which means allow multiple teams... I'm updating the Addons now. So, to fix, you'll need to update to the latest Addon versions. Here's the list and their status:

• BSkyBlock
• AcidIsland
• AOneBlock - already has the setting in config.yml but default was set to false. Change to true
• CaveBlock
• SkyGrid
• Boxed
• Parkour

The config.yml setting you want to look for is:

  # Disallow team members from having their own islands.
  disallow-team-member-islands: true

[tastybento]

Latest SkyGrid already uses the latest API, so should be covered. I'll add the config though for folks who want it.

[tastybento]

All of these should be done either in release or SNAPSHOT now.