Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins settings are set based on the location of the user, not the command #2268

Closed
tastybento opened this issue Jan 11, 2024 · 1 comment · Fixed by #2271
Closed

Admins settings are set based on the location of the user, not the command #2268

tastybento opened this issue Jan 11, 2024 · 1 comment · Fixed by #2271
Assignees

Comments

@tastybento
Copy link
Member

Expected behavior

Executing /acid settings when in the BSlyBlock world should change the settings for AcidIsland.

Observed/Actual behavior

Executing /acid settings when in the BSlyBlock world should change the settings for BSkyBlock.

Steps/models to reproduce

  1. Execute /acid settings when in the BSlyBlock world.
  2. Make a change that is different to what is currently set
  3. Go to AcidIsland world
  4. Execute /acid settings - the setting is not set

BentoBox version

> bbox v
[23:02:32 INFO]: Running PAPER 1.20.4.
[23:02:32 INFO]: BentoBox version: 2.0.0-SNAPSHOT-LOCAL
[23:02:32 INFO]: Database: JSON
[23:02:32 INFO]: Loaded Game Worlds:
[23:02:32 INFO]: acidisland_world (AcidIsland): Overworld, Nether, The End
[23:02:32 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether*, The End
[23:02:32 INFO]: Loaded Addons:
[23:02:32 INFO]: AcidIsland 1.18.2-SNAPSHOT-LOCAL (ENABLED)
[23:02:32 INFO]: Border 4.2.1-SNAPSHOT-LOCAL (ENABLED)
[23:02:32 INFO]: BSkyBlock 1.17.0-SNAPSHOT-b751 (ENABLED)
[23:02:32 INFO]: Level 2.12.0-SNAPSHOT-LOCAL (ENABLED)
[23:02:32 INFO]: Visit 1.7.0-SNAPSHOT (ENABLED)

Plugin list

No response

Other

No response

@tastybento tastybento self-assigned this Jan 11, 2024
@tastybento
Copy link
Member Author

@BONNe FYI. I found this bug. It's a long-standing one because the world context is not shared when making the GUI and the flags, so the code is currently taking the world of the user, which may not be the correct world. I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant