Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockPlaceEvent in non-BBOX world #1172

Closed
SlimeDog opened this issue Feb 6, 2020 · 7 comments
Closed

BlockPlaceEvent in non-BBOX world #1172

SlimeDog opened this issue Feb 6, 2020 · 7 comments
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug Type: Conflict Issue is likely caused by another plugin
Milestone
1.11.1

Comments

@SlimeDog
Copy link

SlimeDog commented Feb 6, 2020

Description

Describe the bug

We are seeing a fair number of these when moving around in non-BentoBox worlds.

Steps to reproduce the behavior

Unclear. Actions include deleting blocks.

BentoBox Version (Mandatory)

>bbox version
[11:46:00] [Server thread/INFO]: Running SPIGOT 1.15.2.
[11:46:00] [Server thread/INFO]: BentoBox version: 1.11.1-SNAPSHOT-b1640
[11:46:00] [Server thread/INFO]: Database: JSON
[11:46:00] [Server thread/INFO]: Loaded Game Worlds:
[11:46:00] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[11:46:00] [Server thread/INFO]: Loaded Addons:
[11:46:00] [Server thread/INFO]: Biomes 1.6.0.1-SNAPSHOT-b151 (ENABLED)
[11:46:00] [Server thread/INFO]: BSkyBlock 1.11.1-SNAPSHOT-b591 (ENABLED)
[11:46:00] [Server thread/INFO]: Challenges 0.9.0-SNAPSHOT-b398 (ENABLED)
[11:46:00] [Server thread/INFO]: ExtraMobs 1.11.0.2 (ENABLED)
[11:46:00] [Server thread/INFO]: Level 1.9.4-SNAPSHOT-b345 (ENABLED)

Plugins (Optional)

Console ERROR

[10:42:31] [Server thread/ERROR]: Could not pass event BlockPlaceEvent to BentoBox v1.11.1-SNAPSHOT-b1640
org.bukkit.event.EventException: null
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:319) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:541) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:528) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at com.rngservers.irondoors.events.Events.onIronDoor(Events.java:39) ~[?:?]
        at jdk.internal.reflect.GeneratedMethodAccessor417.invoke(Unknown Source) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:315) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:541) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:528) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:442) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.PlayerInteractManager.a(PlayerInteractManager.java:441) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1250) ~[?:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.PacketPlayInUseItem.a(PacketPlayInUseItem.java:27) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(SourceFile:144) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(SourceFile:118) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:918) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:911) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(SourceFile:127) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:895) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:828) [spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.NullPointerException
        at world.bentobox.bentobox.listeners.flags.protection.PlaceBlocksListener.onBlockPlace(PlaceBlocksListener.java:30) ~[?:?]
        at jdk.internal.reflect.GeneratedMethodAccessor527.invoke(Unknown Source) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:315) ~[spigot-1.15.2.jar-2020-02-02-2025:git-Spigot-c574e08-807a677]
        ... 27 more
@Poslovitch Poslovitch added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Feb 6, 2020
@Poslovitch Poslovitch added this to the 1.11.1 milestone Feb 6, 2020
@tastybento tastybento self-assigned this Feb 7, 2020
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Feb 7, 2020
@tastybento
Copy link
Member

I notice that you filed almost the same bug here: https://github.com/flori-schwa/VarLight/issues/24

Can you tell me more about Irondoors? I see this line:

com.rngservers.irondoors.events.Events.onIronDoor(Events.java:39)

It seems to be involved and is violating the @nonnull rule for item in hand when calling this event. I see that VarLight put in a fix and we can do the same but the root cause is Irondoors creating an event with null in hand items.

@tastybento tastybento added the Type: Conflict Issue is likely caused by another plugin label Feb 7, 2020
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 7, 2020
@tastybento
Copy link
Member

tastybento commented Feb 7, 2020 •
edited
Loading

If IronDoors is your own plugin then I recommend changing the code to use an AIR itemstack to help with compatibility.

@SlimeDog
Copy link
Author

SlimeDog commented Feb 7, 2020

Good research. I guess this issue still exists with IronDoors 1.2. :(

Please file an issue with IronDoors. You understand better than I what the underlying issue is; I just see the results. The dev is reasonably responsive.

@tastybento
Copy link
Member

I don't know where this plugin comes from. Do they have a GitHub?

@SlimeDog
Copy link
Author

SlimeDog commented Feb 7, 2020

https://www.spigotmc.org/resources/irondoors.73022/
https://gitlab.com/RandomUnknown/irondoors/issues

@tastybento
Copy link
Member

Okay done: https://gitlab.com/RandomUnknown/irondoors/issues/1

@SlimeDog
Copy link
Author

SlimeDog commented Feb 7, 2020

Thanks.

@BONNe BONNe mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug Type: Conflict Issue is likely caused by another plugin
Projects
None yet
Milestone
1.11.1
Development

No branches or pull requests
3 participants
@tastybento @SlimeDog @Poslovitch