Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PvP global setting #1053

Open
PhanaticD opened this issue Dec 1, 2019 · 6 comments
Open

PvP global setting #1053

PhanaticD opened this issue Dec 1, 2019 · 6 comments
Assignees
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@PhanaticD
Copy link

Description

Is your feature request related to a problem?

Currently pvp seems to not have a global setting for the world available anywhere, I would like this to be able to be set, whether it be in the config or the world flags GUI

Describe the solution you'd like us to implement.

Describe alternatives you've considered.

Additional context

@PhanaticD
Copy link
Author

also I am curious if I set it to enabled, would it overwrite any existing island settings

@Poslovitch Poslovitch added Status: Pending Waiting for a developer to start working on this issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Dec 1, 2019
@Poslovitch
Copy link
Member

also I am curious if I set it to enabled, would it overwrite any existing island settings

I personally think it should override the existing island settings (regarding PVP), and maybe even prevent them from being edited... But that'd be prone to confusion - and that'd require an addition to the Flags API.

Any thoughts about this @tastybento ?

@tastybento
Copy link
Member

tastybento commented Dec 21, 2019

Can't you just set the default island settings for PVP to true and then reset the island settings?

# These are the default settings for new islands
  default-island-settings:
    PVP_END: true
    PVP_NETHER: true
    ANIMAL_SPAWN: true
    MONSTER_SPAWN: true
    FIRE_SPREAD: true
    PVP_OVERWORLD: true

and then:

bsb resetflags PVP_OVERWORLD
bsb resetflags PVP_NETHER
bsb resetflags PVP_END

@PhanaticD
Copy link
Author

no, because i need pvp enabled in areas that are not part of a island

@tastybento
Copy link
Member

Okay. I understand now. It's actually a world setting for PVP outside of what islands have.

@astirling
Copy link

astirling commented Oct 25, 2020

I just want to add, I'd love to see this feature also. We're trying to setup an anarchy SB and can not get PVP to work outside the island protection ranges in the bskyblock_world. I see global settings for most things, but PVP, in the configuration. docs.bentobox.world is quite lacking in documentation, so I found myself here.

@tastybento tastybento self-assigned this Oct 25, 2020
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Development

No branches or pull requests

4 participants