Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During initial wallet setup, highlight substitution errors, but don't correct anything. #55

Closed
BenWestgate opened this issue Jul 26, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester

Comments

@BenWestgate
Copy link
Owner

So in summary, error correction implementations:

  • During initial wallet setup, behave like bech32: you can highlight substitution errors, but don't correct anything.
  • During recovery, then do whatever you can, including grinding for insertions/deletions, to find the seed. Then show the user the set of corrections and make them re-enter the corrected string (in the hope that they'll make a new corrected backup) before using it.

Originally posted by @apoelstra in BlockstreamResearch/codex32#54 (comment)

Currently implementing 1 edit correction and displaying the suggested code word in "Restore wallet"
Should implement full string substitution detection and highlighting the input string red. "You have typed Errors in the following locations" Press enter to see the correct string again. Do not fix anything at all in their input field. Not even non-bech32 characters, capitalization or length.

@BenWestgate
Copy link
Owner Author

The corrections get displayed in "Restore Wallet" (I might highlight with 2 colors the visible corrections like insertions and substitutions. Using the familiar substitution color they saw during create) I can actually "correct a ton of errors if they're things like B = 8, O = 0, I = 1/l, etc, those suggestions would be in addition to the brute force edit_depth of 1.
And they should be displayed by the python library, not the messy bash function

@BenWestgate BenWestgate added enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester labels Jul 27, 2023
@BenWestgate
Copy link
Owner Author

Highlighting of substitution errors in "create a new seed" is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: medium Issues raised by 1 tester
Projects
None yet
Development

No branches or pull requests

1 participant