Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain cycle on deleteClosure #3

Open
adriencog opened this issue Sep 9, 2017 · 0 comments
Open

Retain cycle on deleteClosure #3

adriencog opened this issue Sep 9, 2017 · 0 comments

Comments

@adriencog
Copy link

I love your declarative API approach. I had a similar one on larger scale but noticed many retain cycles with due to closures.
In fact, in your example, you created a retain cycle on the deleteClosure too.

        self.tableViewRenderer.tableViewModel = tableViewModelForUserList(
            users,
            deleteClosure: deleteUser
        )

Changing the closure to the following fixed it:

        self.tableViewRenderer.tableViewModel = tableViewModelForUserList(
            users,
            deleteClosure: { [unowned self] indexPath in
                self.deleteUser(indexPath)
        })

However, passing closures this way is less convenient but I couldn't find another way to solve retain cycles.
Any idea of how this could be improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant