Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert_from_bytes has wrong argument name or docstring #253

Open
t-ae opened this issue Jan 30, 2023 · 0 comments
Open

convert_from_bytes has wrong argument name or docstring #253

t-ae opened this issue Jan 30, 2023 · 0 comments

Comments

@t-ae
Copy link

t-ae commented Jan 30, 2023

First argument of convert_from_bytes is pdf_file.

pdf2image/pdf2image/pdf2image.py

Line 277 in d415156

pdf_file: bytes,

Its docstring calls it pdf_bytes.

pdf2image/pdf2image/pdf2image.py

Line 302 in d415156

:param pdf_bytes: Bytes of the PDF that you want to convert

pdf_bytes sounds more accurate for me, but renaming can break compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t-ae