Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dropbar menu for ui.select (opt-in) #120

Merged
merged 3 commits into from
Dec 14, 2023
Merged

feat: use dropbar menu for ui.select (opt-in) #120

merged 3 commits into from
Dec 14, 2023

Conversation

willothy
Copy link
Collaborator

@willothy willothy commented Dec 9, 2023

No description provided.

@Bekaboo
Copy link
Owner

Bekaboo commented Dec 9, 2023

Awesome work. IMO better to just provide the function and let users override ui.select themselves. Need to provide some guidance/instructions in the README.

@willothy
Copy link
Collaborator Author

willothy commented Dec 9, 2023

Awesome work. IMO better to just provide the function and let users override ui.select themselves. Need to provide some guidance/instructions in the README.

Thanks! Sounds good, I like that approach more now that I think about it.

@willothy willothy force-pushed the ui-select branch 2 times, most recently from bf4e455 to cfd7eeb Compare December 12, 2023 18:36
@willothy willothy marked this pull request as ready for review December 12, 2023 18:37
@willothy willothy requested a review from Bekaboo December 12, 2023 18:39
@Bekaboo
Copy link
Owner

Bekaboo commented Dec 12, 2023

Should also update vim help file. If you do not have time I can do it. I have to admit it is pretty cumbersome to write all these docs manually. Have to find a way to generate them automatically.

@willothy
Copy link
Collaborator Author

Will do! My bad, I always forget about vimdoc. Definitely would be good to setup panvimdoc or something, but from my experience it can be tricky to get working with a readme that isn't designed from scratch to work with panvimdoc

@willothy
Copy link
Collaborator Author

Ok docs should be good, hope the formatting is ok

@Bekaboo
Copy link
Owner

Bekaboo commented Dec 14, 2023

Looks great, thanks!

@Bekaboo Bekaboo merged commit 86a7736 into Bekaboo:master Dec 14, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bekaboo Bekaboo Awaiting requested review from Bekaboo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willothy @Bekaboo