Cast table node exceptions into ParserExceptions when throwing #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranmcnulty
force-pushed
the
table-row-counts
branch
from
67bc894 to
6f7a557
Compare
stof
requested changes
Feb 8, 2021
src/Behat/Gherkin/Parser.php
Outdated
| try { | ||
| return new TableNode($this->parseTableRows()); | ||
| } | ||
| catch(NodeException $e) { |
There was a problem hiding this comment.
should be on the previous line to follow PSR-2/PSR-12
src/Behat/Gherkin/Parser.php
Outdated
| } | ||
| catch(NodeException $e) { | ||
| throw new ParserException( | ||
| $e->getMessage() . $this->file ? ' in file '.$this->file : '', |
There was a problem hiding this comment.
you are missing braces around the ternary. The current code is executed as ($e->getMessage() . $this->file) ? ' in file '.$this->file : '' which is not what you want.
src/Behat/Gherkin/Parser.php
Outdated
| @@ -565,7 +566,16 @@ protected function parseExamples() | |||
| */ | |||
| protected function parseTable() | |||
| { | |||
| return new TableNode($this->parseTableRows()); | |||
| try { | |||
| return new TableNode($this->parseTableRows()); | |||
There was a problem hiding this comment.
I would probably keep the parseTableRows outside the try/catch so that we catch only the exceptions from TableNode.
ciaranmcnulty
force-pushed
the
table-row-counts
branch
from
bc94163 to
a79bb0a
Compare
stof
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than leaking this, we should make a ParserException
Closes #212