Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-open Generalized Hyperbolic Stretch #7251

Open
wants to merge 126 commits into
base: dev
Choose a base branch
from
Open

Re-open Generalized Hyperbolic Stretch #7251

wants to merge 126 commits into from

Conversation

Desmis
Copy link
Collaborator

@Desmis Desmis commented Nov 14, 2024

I accidentally merged the PR GHS #7210
I reverted with the PR 7250

I open this new PR... same code

@waynesutton50
Copy link

waynesutton50 commented Nov 25, 2024

@Desmis there is an anomaly when using GHS with a DCP (Color Management > Input Profile >Custom). To reproduce:

-Open an image and apply a DCP .
-Check the DCP parameter boxes ("Tone curve", "Look table", etc.)
-Create a RT-Spot (either Normal, Full Image or Global).
-Select the GHS tool and activate the "Stretch factor" slider
-Toggle any one of the checked DCP parameter boxes on and off repeatedly.

The image will become progressively brighter. The only way to reset the image to its original state is to click on the Camera Standard Input Profile and then reselect the DCP profile.
EDIT: See also issue #7147

@Desmis
Copy link
Collaborator Author

Desmis commented Nov 27, 2024

@waynesutton50 @Lawrence37

This bug which was reported in July 2024, in the "apseimprov" branch has been addressed in the corresponding PR. DCP had interference with Abstract Profile.

I changed the "events" in refreshmap.cc", for DCP events
#7111

ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPToneCurve, 21 july 2024

ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyLookTable,  21 july 2024

ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyBaselineExposureOffset, 21 july 2024

What have we been waiting for for several months, the last exchange is on September 9th, for the PR 7111 ?
I added some modifications following small bugs found by me, or improvements in visualization of SE wavelets changes. I'm not going to reopen a new PR on the same subject.

Jacques

@Lawrence37
Copy link
Collaborator

I keep seeing new commits, so I have been prioritizing bug fixes and other pull requests with my (very) limited time. Let us know if you want feedback or if the pull request is ready for review.

@Desmis
Copy link
Collaborator Author

Desmis commented Nov 28, 2024

@Lawrence37

The PR #7111 s ready for review.

But I understand :)

Jacques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants