Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable serverside 515.1614 #9124

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Enable serverside 515.1614 #9124

wants to merge 34 commits into from
+6 −13

Conversation

Crossedfall
Copy link
Member

About The Pull Request

Enables serverside 515 support.

Tested with 1589 client, 1608 server, works.

image

itsmeow and others added 16 commits March 30, 2023 18:15
@itsmeow
SendMaps Beta Test (DO NOT MERGE)
d69d520
@itsmeow
Update auxmos for server
83acaee
@itsmeow
Something something signatures
2088592
@itsmeow
Merge remote-tracking branch 'origin/master' into sendmaps-beta
2147d9e
@itsmeow
Merge remote-tracking branch 'origin/master' into sendmaps-beta
fc13665
@itsmeow
515.1605
6bbd19d
@itsmeow @Crossedfall
Update code/_compile_options.dm
65ec2af 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update code/_compile_options.dm
191f636 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update dependencies.sh
46d9791 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update code/_compile_options.dm
548073a 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update code/_compile_options.dm
f77f7fc 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update dependencies.sh
837bb19 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update code/_compile_options.dm
8b55c55 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update dependencies.sh
a91f442 
Co-authored-by: Crossedfall <[email protected]>
@itsmeow @Crossedfall
Update code/_compile_options.dm
18e3402 
Co-authored-by: Crossedfall <[email protected]>
@Crossedfall
Merge branch 'sendmaps-beta' into sendmapsbeta
c03650b
@Crossedfall Crossedfall requested a review from itsmeow May 30, 2023 19:23
@Crossedfall Crossedfall mentioned this pull request May 30, 2023
Closed
@Crossedfall
Copy link
Member Author

There is a known issue with 515.1607 and 515.1608 that conflicts with our direct calls of text(). Lummox said that they will work to fix it. We should also probably look at removing those since that practice has been depreciated.

@Crossedfall
Copy link
Member Author

Related issue for the text() calls #9130

@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label May 31, 2023
Crossedfall
Crossedfall commented May 31, 2023
View reviewed changes
code/_compile_options.dm Outdated Show resolved Hide resolved
Crossedfall
Crossedfall commented May 31, 2023
View reviewed changes
code/_compile_options.dm Outdated Show resolved Hide resolved
Crossedfall
Crossedfall commented May 31, 2023
View reviewed changes
dependencies.sh Outdated Show resolved Hide resolved
@Crossedfall
Copy link
Member Author

Just going to bump this out really far while we're in the testing phase, and I'll constrain it again when it's actually ready for release.

@Crossedfall Crossedfall changed the title Enable serverside 515.1608 (new) Enable serverside 515.1609 (new) May 31, 2023
@Crossedfall
Copy link
Member Author

Now that BYOND 515 is in the stable channel will we be seeing a merge of this?

CI says no.

@lowwy lowwy mentioned this pull request Mar 23, 2024
Closed
@TheCatbag TheCatbag mentioned this pull request Apr 7, 2024
Closed
@williamcll williamcll mentioned this pull request Apr 16, 2024
Closed
@Ragantis Ragantis mentioned this pull request May 13, 2024
Closed
@FriendlyIsisMember FriendlyIsisMember mentioned this pull request May 13, 2024
Closed
@SpagootyEggant SpagootyEggant mentioned this pull request May 22, 2024
Closed
@XeonMations XeonMations mentioned this pull request May 23, 2024
Open
@Certified-Air-Breather Certified-Air-Breather mentioned this pull request May 30, 2024
Open
@lowwy lowwy mentioned this pull request Jun 5, 2024
Open
@kiekatz kiekatz mentioned this pull request Aug 3, 2024
Closed
@Tsar-Salat Tsar-Salat mentioned this pull request Aug 4, 2024
Closed
@Crossedfall Crossedfall changed the title Enable serverside 515.1633 Enable serverside 515.1642 Aug 15, 2024
@Crossedfall Crossedfall changed the title Enable serverside 515.1642 Enable serverside 515.1614 Aug 16, 2024
@Crossedfall
Copy link
Member Author

Bumping to latest just caused a bunch of crashes. Reverting :c

@SuperPantsHero SuperPantsHero mentioned this pull request Sep 5, 2024
Closed
@Marshmellow105 Marshmellow105 mentioned this pull request Oct 15, 2024
Open
@Therealdoooc213 Therealdoooc213 mentioned this pull request Nov 8, 2024
Open
@Marshmellow105 Marshmellow105 mentioned this pull request Nov 17, 2024
Open
@PerishedFraud PerishedFraud mentioned this pull request Nov 19, 2024
Open
@h42-real h42-real mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerfulBacon PowerfulBacon PowerfulBacon approved these changes

@itsmeow itsmeow Awaiting requested review from itsmeow

Assignees
No one assigned
Labels
DO NOT MERGE Test Merged This PR is currently in rotation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Crossedfall @EvilDragonfiend @Tsar-Salat @JixS4v @PowerfulBacon @itsmeow