Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors ebows and kpa's to the same parent #11939

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Nov 24, 2024

About The Pull Request

Ebows and kpa's have been refactored to use a new recharging parent typepath

credit to Fikou

Why It's Good For The Game

Shitcode made weapons that refilled with a cooldown, like energy bows, a child of pneumatic kinetic cannons.

This has a lot of issues, like every feature you put on KPAs needing to be carefully managed and returned lest you suddenly be able to put modkits on ebows or some shit lmao.

Ive dealt with this 3 times in previous prs and I don't really feel like dealing with it anymore, thus this pr.

Testing Photographs and Procedure

Screenshots&Videos
dreamseeker_GdlpImTRBl.mp4

Changelog

🆑 rkz, Fikou
refactor: refactored pkas and ebows. There should be no discernable behavior changes.
tweak: changes the empty chamber gun alert to be more succinct
/:cl:

@github-actions github-actions bot added the Mapping DMM Change label Nov 24, 2024
@Rukofamicom
Copy link
Contributor

Rukofamicom commented Nov 26, 2024

Well shit, now I can't put the ebow in my miner gear anymore. I hope my comment didn't motivate this lmao

Not enough time to actually look at the whole thing, but it looks good at first look with the few minutes I had to spare. Didn't check for the paths update, but as long as it's there and good this should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants