Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posibrains no longer limited to 1, but cyborgs cannot have repeat names #11426

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

Rukofamicom
Copy link
Contributor

@Rukofamicom Rukofamicom commented Sep 4, 2024

About The Pull Request

Effectively reverts #6807 in favor of one of the alternative ideas posted.

Instead of limiting posibrain spawns to one, if you attempt to become a cyborg name that has already existed your name will be randomized obscuring your identity as a respawn. Even normal cyborg players are expected not to use meta knowledge they gained before spawning so this should not cause any more issues than any other ghost spawn may.

Why It's Good For The Game

There is no reason to have a single ghost role restricted to single-use while others are not.

This is also in line with the desire to enable more ghost spawns, allowing more players to rejoin the round after death, including silicon players.

Testing Photographs and Procedure

image
image
image

Changelog

🆑
tweak: Players are no longer limited to a single positronic brain per round.
tweak: Cyborgs may no longer have duplicate names, unless they are being rebuilt from the same brain that was previously a cyborg - if you are respawning as a fresh cyborg and do not choose a different character profile first, you will be given the default cyborg name instead of becoming a second copy of the same cyborg.
/:cl:

code/__HELPERS/mobs.dm Outdated Show resolved Hide resolved
@Rukofamicom
Copy link
Contributor Author

Oversight has been fixed, this is safe to merge and actually works instead of just appearing to work now.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transforming modules calls update name through update_module_innate. Putting an MMI in a borg also calls that function. This will throw errors in chat about your name being randomised when you transform (even though the name doesn't actually get randomised). Also if a cyborg is detonated and then the MMI is placed in a borg, it will likely reject the name. There needs to be some way to distinguish between a new cyborg and an existing cyborg getting the same name.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2024
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 8, 2024
@Rukofamicom
Copy link
Contributor Author

weird, no failed checks but it claims there were

Merged via the queue into BeeStation:master with commit 94682fc Sep 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants