[Port/Refactor] Job Refactor

[XeonMations]

About The Pull Request

Requires:

• [Port] Departmental Refactor #11209

Dehardcodes alot of stuff, bringing our jobs to updated TG standards.

Ports fully or bits of code from:

• Job refactor: strings to references and typepaths tgstation/tgstation#59841
• Adds ability to request the spare ID safe codes on shifts with no captain or acting captain. tgstation/tgstation#57460
• Job refactor 2: less hardcoded lists tgstation/tgstation#60578
• roundstart offstation antagonists (wizards, nuke ops...) no longer have quirk assigned to them. tgstation/tgstation#60987
• De-hardcodes jobs tgstation/tgstation#64193
• Cleans Job lists (hardcoded and not) tgstation/tgstation#64596
• Dehardcodes HR core blacklist tgstation/tgstation#77075
• Sign up for Cargorilla from the lobby tgstation/tgstation#79776 (job flags and stuff, not the actual cargorilla)
• adds head of staff job flag tgstation/tgstation#80415
• Removing a job now removes its positions tgstation/tgstation#82015
• adds head of staff job flag tgstation/tgstation#80415
• Bridge Assistant Station Trait tgstation/tgstation#80279 (Job flags, again, not the actual station trait)
• Fully implements the ID Card design document tgstation/tgstation#56910 (acting captain assignment code)
• Fixes security not getting assigned to departments tgstation/tgstation#60349
• Fix roundstart crewmembers not getting their radio hint message / Examine blocks out starting job information tgstation/tgstation#78647

Why It's Good For The Game

QoL for custom jobs and stuff like that, also helps to bring our code up to date.

Testing Photographs and Procedure

Screenshots&Videos

Things for when there is noone in a command position:


(Departures lounge is the location of the communications console, in this case, on RuntimeStation: Departures Lounge)

Changelog

🆑 EvilDragonfiend, Rohesie, Timberpoes, Fikou, JohnFulpWillard, Jacquerel, MrMelbert, Ghommie, XeonMations
refactor: Dehardcoded a lot of job code, added job flags, as well as making the code hopefully better
add: Communications Consoles now have the ability to request codes to the spare ID safe when there are no crew members in the chain of command on the shift. This can be done without logging into the comms console.
/:cl:

[EvilDragonfiend]

TG's job code isn't really great so that I won't recommend porting it.
Note that this would have a high chance to get a close key from me.

[EvilDragonfiend]

I skimmed, but the majour problem comes from something that you really shouldn't port.
The port is trying to make ROLE into JOB codes, to merge ROLE and JOB codes into one. This isn't a good refactor, only increases the complexity of the code to maintain.

[EvilDragonfiend]

🔑With the reason said above, I put my key.

Why Role and Job shouldn't be merged?

Simple. This means roles like Heretic, Traitor, something else as a job, while crews should have a job with such special role.
Many roles shouldn't be a job, but the code makes them as a job. (I know heretic, traitor isn't included here, but we really shouldn't have others as job.)

What should I do port these correctly?

I really recommend posting a port PR one by one rather than trying to bring everything here.

[XeonMations]

Currently all given changes were purely from tgstation/tgstation#59841 so far, as requested/reverting reverted all changes that merged roles and jobs.

[PowerfulBacon]

Getting rid of special role is a good idea, does this mean that assigned_role is a list now so people can have multiple job role at one?

Job refactor 1 is a good PR, using strings in GetJob is kinda silly and typepaths are way better. Job refactor 2 looks good too.

[EvilDragonfiend]

Getting rid of special role is a good idea, does this mean that assigned_role is a list now so people can have multiple job role at one?

This PR doesn't do that.

Job refactor 1 is a good PR, using strings in GetJob is kinda silly and typepaths are way better. Job refactor 2 looks good too.

typepath check is not any better. when you can just do assigned_role.title == JOB_NAME_CAPTAIN instead of is_job_captain(job), I don't think having N size of is_job_this() macro should be a thing.
I don't mind changing assigned_role into var/datum/job/assigned_role, but what I was addressing isn't related with it.

[EvilDragonfiend]

Lifting the key since the majour concern has been resolved.

[XeonMations]

49 merge conflicts later....

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[XeonMations]

ARE YOU KIDDING ME

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[XeonMations]

okay this entire PR is a shitshow, im pretty sure starting from scratch will be better than... sorting this mess now that #11209 is in

[XeonMations]

Will be continuing this in a clean PR.

[XeonMations]

nevermind, time for actual TGUI i guess