Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Bandanas. Adds GAGS support for Bandanas #11125

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Jun 27, 2024

About The Pull Request

Adds greyscale bandanas from tg. Fixes the error sprite worn icon

Ports:

Why It's Good For The Game

Fixes a broken icon, GAGS makes icon management less painful

Testing Photographs and Procedure

Screenshots&Videos
dreamseeker_tekxj3FbH5.mp4

Changelog

🆑 rkz, Ebb-Real, AnturK
add: GAGSifies bandanas
refactor: refactors large mob icons to no longer need snowflaked .dmi sizes. Just edit a variable
/:cl:

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat Tsar-Salat marked this pull request as ready for review August 27, 2024 19:28
@@ -176,21 +176,22 @@ DEFINE_BITFIELD(resistance_flags, list(
))

DEFINE_BITFIELD(flags_1, list(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ordering alphabetically

Copy link

github-actions bot commented Sep 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PestoVerde322
Copy link
Contributor

What about the cage helmet? icons/mob/large-worn-icons/64x64/head.dmi is being removed after all and I see no mentions of it having a new icon adress. Same goes for other former 64x64 icons (which also are lacking on the 🆑). Other than that the icons for the bandana seems good to go.

Copy link
Contributor

@PestoVerde322 PestoVerde322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on the icon front now, approved!

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

The newer fix has been merged, this is now pointless

@Tsar-Salat Tsar-Salat closed this Sep 8, 2024
@Tsar-Salat Tsar-Salat deleted the GAGS-bandanas branch September 8, 2024 14:47
@Tsar-Salat Tsar-Salat restored the GAGS-bandanas branch November 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants