Components should not be blueprint types. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2024
iago-lito
force-pushed
the
dev
branch
7 times, most recently
from
1684652 to
5d1c9e5
Compare
iago-lito
force-pushed
the
blueprints
branch
12 times, most recently
from
5a159d5 to
31c7d43
Compare
iago-lito
force-pushed
the
blueprints
branch
2 times, most recently
from
cf1f51d to
ae1e0ee
Compare
iago-lito
force-pushed
the
blueprints
branch
5 times, most recently
from
e4711f3 to
1609a56
Compare
iago-lito
force-pushed
the
blueprints
branch
2 times, most recently
from
63439f8 to
598f7e2
Compare
iago-lito
force-pushed
the
blueprints
branch
4 times, most recently
from
b362b6b to
053855d
Compare
iago-lito
force-pushed
the
blueprints
branch
3 times, most recently
from
c8f31df to
11e6cb9
Compare
iago-lito
force-pushed
the
blueprints
branch
5 times, most recently
from
e59db3e to
801f34f
Compare
iago-lito
added a commit
that referenced
this pull request
Dec 20, 2024
This deep refactoring of the Framework addresses and fixes #139. It fixes the semantics of the components library (*e.g.* `OmegaFromRawEdges` and `OmegaFromAllometry` are *not* two separate components) while making it more flexible and future-proof. Take this opportunity to tick the numerous additional Framework `TODO`s, contributing to polishing the whole library API experience. Summarize changes in a fresh `CHANGELOG.md`, suggesting to issue v0.2.1.
iago-lito
force-pushed
the
blueprints
branch
from
801f34f to
7336033
Compare
This deep refactoring of the Framework addresses and fixes #139. It fixes the semantics of the components library (*e.g.* `OmegaFromRawEdges` and `OmegaFromAllometry` are *not* two separate components) while making it more flexible and future-proof. Take this opportunity to tick the numerous additional Framework `TODO`s, contributing to polishing the whole library API experience. Summarize changes in a fresh `CHANGELOG.md`, suggesting to issue v0.2.1.
iago-lito
force-pushed
the
blueprints
branch
from
7336033 to
378e095
Compare
|
This is finally ready for review 🎉 As expected, the refactoring surfaced as minor breaking API changes, so we'd need to bump our version number to merge this. See the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this design mistake: blueprints and components should be two separate types hierarchies.
Using singleton component instances as ergonomical handles should improve #131.
Take this opportunity to better unify
broughtblueprint, eitherimplied,embeddedorunbroughtdepending on blueprint value.This will surface as breaking API changes, but I expect them to remain minor. One major positive change I expect is the simplification of all code within
src/components/: this should not become so complex than no one can hack in.