Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Reading uses too much memory due to full file reads #3347

Closed
ShreyasKhandekar opened this issue Jun 19, 2024 · 0 comments · Fixed by #3348
Closed

CSV Reading uses too much memory due to full file reads #3347

ShreyasKhandekar opened this issue Jun 19, 2024 · 0 comments · Fixed by #3348
Labels
bug Something isn't working

Comments

@ShreyasKhandekar
Copy link
Contributor

In the CSVMsg module, read_csv uses too much memory which causes Segmentation fault when the program runs out of memory.

This is arising due to the following pattern which appeared in many places in the module:

var lines = reader.lines().strip();

This reads the entire file into memory, and when the file sizes are huge relative to the memory available, the server crashes.
#3238 improved the situation here by eliminating this pattern from read_files_into_dist_array, but lsCSVMsg and get_info still use this pattern and cause crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant