Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment in aggregation allocation #2677

Closed
bmcdonald3 opened this issue Aug 16, 2023 · 1 comment
Closed

Fix alignment in aggregation allocation #2677

bmcdonald3 opened this issue Aug 16, 2023 · 1 comment
Assignees
@bmcdonald3

Comments

@bmcdonald3
Copy link
Contributor

In #2489, I had replaced calls to c_aligned_alloc to allocate and accidentally swapped the position of the padding and the number of locales in one spot, so reverting that here.

This was seen to cause crashes at 512 locales and the fix was identified by @ronawho.
@bmcdonald3 bmcdonald3 self-assigned this Aug 16, 2023
@stress-tess
Copy link
Member

Looks like we didn't actually put the closing keyword in the description of this PR so it didn't close automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmcdonald3 bmcdonald3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmcdonald3 @stress-tess