Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused return value from write method in MulitTypeSymbolTable #1865

Closed
jeremiah-corrado opened this issue Oct 27, 2022 · 0 comments · Fixed by #1866
Closed

Unused return value from write method in MulitTypeSymbolTable #1865

jeremiah-corrado opened this issue Oct 27, 2022 · 0 comments · Fixed by #1866

Comments

@jeremiah-corrado
Copy link
Contributor

In parseJson(), the return value from mem.writer().write(names) is stored but never used:

proc parseJson(names:string): [] string throws {
var mem = openmem();
var writer = mem.writer().write(names);
var reader = mem.reader();
var num_elements = 0;

In an upcoming Chapel PR (chapel-lang/chapel#20907), the fileWriter.write method will no longer return a boolean value, meaning that MulitTypeSymbolTable would fail to compile.

I'll open a PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant