Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate grouping and sorting semantics #1348

Open
1 of 2 tasks
stress-tess opened this issue May 3, 2022 · 1 comment
Open
1 of 2 tasks

Separate grouping and sorting semantics #1348

stress-tess opened this issue May 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@stress-tess
Copy link
Member

stress-tess commented May 3, 2022

This issue contains the requested functionality previously captured in Issue #846 that was not addressed by PR #1330

  • Separate grouping and sorting semantics
    • argsort and coargsort should actually sort the array(s). Currently, calling coargsort on a list including a Strings or Categorical will only group, not sort.
    • GroupBy should guarantee grouping, but not necessarily sorting. Strings and Categorical should have separate APIs for sorting and grouping, and GroupBy should call the latter.

The high-level actions required by this issue are:

  • Create a server message specifically for GroupBy that takes over the grouping logic currently employed by coargsort
  • Modify coargsort to actually sort the data, rather than just grouping it (for strings)

@reuster986 or anyone else, feel free to add anything I missed from the original issue

@stress-tess stress-tess added the enhancement New feature or request label May 3, 2022
@stress-tess
Copy link
Member Author

Note this issue is related to and summarizes the conversation in #677. I would recommend closing that issue in favor of this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant