Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe arange() usage Clean-up #1236

Closed
Ethan-DeBandi99 opened this issue Mar 28, 2022 · 0 comments · Fixed by #1281
Closed

Dataframe arange() usage Clean-up #1236

Ethan-DeBandi99 opened this issue Mar 28, 2022 · 0 comments · Fixed by #1281
Assignees
@joshmarshall1
Labels
good first issue Good for newcomers In Progress Work on ticket is in progress / ticket is actively being worked

Comments

@Ethan-DeBandi99
Copy link
Contributor

This was identified during review of #1190. There are several instances where arange() is being called as arange(0, self._size, 1) (or similar). Because 0 is the default for start and 1 is the default for stride, This can be simplified to arange(self._size) since the defaults will automatically be applied.

Files to Update

  • arkouda/dataframe.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshmarshall1 joshmarshall1

Labels
good first issue Good for newcomers In Progress Work on ticket is in progress / ticket is actively being worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1236 - Cleanup of arange unnecessary arguments joshmarshall1/arkouda
2 participants
@Ethan-DeBandi99 @joshmarshall1