Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: restrict combinations of versions of dependencies #75

Open
ap-- opened this issue Sep 2, 2023 · 0 comments
Open

Dependencies: restrict combinations of versions of dependencies #75

ap-- opened this issue Sep 2, 2023 · 0 comments
Assignees
Labels
investigate 🕵️ Needs some investigation

Comments

@ap--
Copy link
Collaborator

ap-- commented Sep 2, 2023

This is an interesting issue. We depend on tifffile, and specifically its zarr interface. Since we don't want to depend on tifffile[all] because we don't need matplotlib and other optional dependencies of tifffile, we opted for:

tiffslide/setup.cfg

Lines 36 to 42 in 8bea5a4

install_requires =
imagecodecs
fsspec!=2022.11.0,!=2023.1.0
pillow
tifffile>=2021.6.14
zarr>=2.11.0
typing_extensions>=4.0

Basically manually adding the dependencies we need.
But this can lead to installations in which pip would resolve a working environment, that might have two incompatible versions of imagecodecs and tifffile installed. Here are the compatible versions:

tifffile imagecodecs
>=2023.8.12 >=2023.8.12
>=2023.1.23 >=2023.1.23
>=2022.7.28 >=2022.2.22
>=2022.2.22 >=2021.11.20
>=2021.7.30 >=2021.7.30
>=2021.6.6 >=2021.4.28

I think two incompatible versions of imagecodecs and tifffile might be the cause of imi-bigpicture/wsidicomizer#87 and zarr might catch whatever error and just return black tiles. But I first need to investigate if my guess is actually correct...

@ap-- ap-- added the investigate 🕵️ Needs some investigation label Sep 2, 2023
@ap-- ap-- self-assigned this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate 🕵️ Needs some investigation
Projects
None yet
Development

No branches or pull requests

1 participant