Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/bin/which: no gprintf error on every bash startup if gprintf is not installed #1827

Closed
NariyasuHeseri opened this issue Feb 4, 2021 · 1 comment · Fixed by #1828
Closed

Comments

@NariyasuHeseri
Copy link
Contributor

SSIA

Expected Behavior

No error message should appear

Current Behavior

/usr/bin/which: no gprintf error on every bash startup if gprintf is not installed

Possible Solution

The issue is caused by [ -x "$(which gprintf)" ] && _printf_cmd=gprintf in vendor/github.com/erichs/composure/composure.sh line 61.
Changing the code to something like

```shell
    if [ -x "$(which gprintf)" ]; then
      _printf_cmd=gprintf
    fi 2>/dev/null
```

fixes the issue, but I don't whether I should report this to upstream.

@cornfeedhobo
Copy link
Member

cornfeedhobo commented Feb 4, 2021

@NariyasuHeseri Thanks for reporting this! I saw this bug yesterday but wasn't able to follow up until this morning. I'm going to reach out to erichs and make a PR upstream today. If it looks like they'll be slow to act, we might discuss reverting in the meantime.

As for you today, if this gets too annoying, you can switch to the newest release tag until we fix this. Thanks again!

Edit: this is an issue with tagging and erichs has disabled issues, limiting discussion needed to address this, so we just need to track commits instead.

@cornfeedhobo cornfeedhobo mentioned this issue Feb 5, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants