From f50115fbf5566cc80072b840141c00b90628411c Mon Sep 17 00:00:00 2001
From: tiago <tiagobarros99@ua.pt>
Date: Sun, 24 Jan 2021 15:10:16 +0000
Subject: [PATCH] cleanup modern theme

---
 clean_files.txt                 | 1 +
 themes/modern/modern.theme.bash | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/clean_files.txt b/clean_files.txt
index f94b2dcafe..72dff66d89 100644
--- a/clean_files.txt
+++ b/clean_files.txt
@@ -39,6 +39,7 @@ themes/barbuk
 themes/atomic
 themes/axin
 themes/base.theme.bash
+themes/modern
 
 # plugins
 #
diff --git a/themes/modern/modern.theme.bash b/themes/modern/modern.theme.bash
index cfc20e9a09..a3837be909 100644
--- a/themes/modern/modern.theme.bash
+++ b/themes/modern/modern.theme.bash
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
 SCM_THEME_PROMPT_PREFIX=""
 SCM_THEME_PROMPT_SUFFIX=""
 
@@ -19,14 +21,14 @@ esac
 PS3=">> "
 
 is_vim_shell() {
-	if [ ! -z "$VIMRUNTIME" ]; then
+	if [ -n "$VIMRUNTIME" ]; then
 		echo "[${cyan}vim shell${normal}]"
 	fi
 }
 
 modern_scm_prompt() {
 	CHAR=$(scm_char)
-	if [ $CHAR = $SCM_NONE_CHAR ]; then
+	if [ "$CHAR" = "$SCM_NONE_CHAR" ]; then
 		return
 	else
 		echo "[$(scm_char)][$(scm_prompt_info)]"