Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform CommandAction to type and extend specific enums #549

Closed
abelzis opened this issue Mar 4, 2024 · 1 comment
Closed

Transform CommandAction to type and extend specific enums #549

abelzis opened this issue Mar 4, 2024 · 1 comment
Labels
tech debt Technical debt

Comments

@abelzis
Copy link
Collaborator

abelzis commented Mar 4, 2024

Currently, the CommandAction is an enum, which is too generic and it holds all CommandAction values. My proposal is to add specific enums for each module: enum FieldsCommandAction, enum QueryCommandAction etc. This will provide more clarity from where the actions are raised. If the action is raised from Fields, then the enum should be Fields.

So with this ticket introduce the domain specific enums and refactor the CommandAction to this:
export type CommandAction = QueryCommandAction | FieldsCommandAction | IndexesCommandAction; etc.

@PauliusKu

@abelzis abelzis added the tech debt Technical debt label Mar 4, 2024
@abelzis
Copy link
Collaborator Author

abelzis commented Mar 5, 2024

Solve in #550

@abelzis abelzis closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant