You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move the <DataGrid> part to its own file src/view/app/Components/Layout/Query/QueryFormTable.tsx.
messageEvent function: a) consider adding event types b) move logic to it's own file c) it might even return a tsx element in some cases, which is not clear.
d) in 'data' case there is a headerRenderer function assignment. This should be moved to the QueryFormTable.tsx file mentioned above (see addFilterRendererToColumns). Only the update of the state variables should be done here.
Add interfaces to any type objects. 6. Some of the functions can be moved to outside the main function or to a new file query.ts, e.g. setting column widths or other properties. 7. Please add jsdoc comments to the functions, briefly explaining what it does and describing input parameters and return values. Please use typescript, so describe types, props etc.
The text was updated successfully, but these errors were encountered:
This file is a bit of a mess.
Refactor:
<DataGrid>
part to its own filesrc/view/app/Components/Layout/Query/QueryFormTable.tsx
.a) consider adding event typesb) move logic to it's own filec) it might even return a tsx element in some cases, which is not clear.d) in 'data' case there is a
headerRenderer
function assignment. This should be moved to theQueryFormTable.tsx
file mentioned above (see addFilterRendererToColumns). Only the update of the state variables should be done here.a) add two enums: key and key code (consider https://www.npmjs.com/package/ts-key-enum BUT CREATE SEPARATE TICKET AND BRANCH)
4. Replace view/app/Query/query.tsx components to more 'reactive' components #502any
type objects.6. Some of the functions can be moved to outside the main function or to a new filequery.ts
, e.g. setting column widths or other properties.7. Please add jsdoc comments to the functions, briefly explaining what it does and describing input parameters and return values. Please use typescript, so describe types, props etc.The text was updated successfully, but these errors were encountered: