Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface #41

Closed
treadmillian opened this issue May 25, 2021 · 5 comments · Fixed by #42
Closed

Must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface #41

treadmillian opened this issue May 25, 2021 · 5 comments · Fixed by #42

Comments

@treadmillian
Copy link

Hi,

Is there an issue using Symfony 4.4.24 and PHP 7.4 with the ^2.0 release?

Thanks,
Kevin

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  Cannot load Xdebug - it was already loaded
!!  
!!  Fatal error: Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true) in /Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php on line 67
!!  PHP Fatal error:  Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true) in /Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php on line 67
!!  Symfony\Component\ErrorHandler\Error\FatalError {#10011
!!    -error: array:4 [
!!      "type" => 64
!!      "message" => "Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true)"
!!      "file" => "/Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php"
!!      "line" => 67
!!    ]
!!    #message: "Compile Error: Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true)"
!!    #code: 0
!!    #file: "./vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php"
!!    #line: 67
!!  }
!!  
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
@Baldinof
Copy link
Owner

Hi, you are right, currently it's not working :(

I will try to have a look on it. And to understand why the CI installed Symfony 5 when using lowest deps here https://github.com/Baldinof/roadrunner-bundle/runs/2365909602?check_suite_focus=true#step:6:111

@dhopkalo
Copy link

Today got the same issue, and right now it fixed :) will wait for the merge and release the bug fix version

@Baldinof
Copy link
Owner

The fix is released as v2.0.2, can you confirm it's working for you?

@dhopkalo
Copy link

@Baldinof thanks for the flash fix :), tested all works as expected.

@treadmillian
Copy link
Author

@Baldino Thank you for fixing so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants