From 64868261439a7c4be0605f17953f03f3bdb8c815 Mon Sep 17 00:00:00 2001 From: sebavan Date: Thu, 12 May 2022 17:44:18 +0200 Subject: [PATCH 1/2] Fix Scissor Doc --- packages/dev/core/src/Engines/engine.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/dev/core/src/Engines/engine.ts b/packages/dev/core/src/Engines/engine.ts index b75138805e5..6267e7c2e5c 100755 --- a/packages/dev/core/src/Engines/engine.ts +++ b/packages/dev/core/src/Engines/engine.ts @@ -1082,7 +1082,7 @@ export class Engine extends ThinEngine { /** * Executes a scissor clear (ie. a clear on a specific portion of the screen) - * @param x defines the x-coordinate of the top left corner of the clear rectangle + * @param x defines the x-coordinate of the bottom left corner of the clear rectangle * @param y defines the y-coordinate of the corner of the clear rectangle * @param width defines the width of the clear rectangle * @param height defines the height of the clear rectangle @@ -1096,7 +1096,7 @@ export class Engine extends ThinEngine { /** * Enable scissor test on a specific rectangle (ie. render will only be executed on a specific portion of the screen) - * @param x defines the x-coordinate of the top left corner of the clear rectangle + * @param x defines the x-coordinate of the bottom left corner of the clear rectangle * @param y defines the y-coordinate of the corner of the clear rectangle * @param width defines the width of the clear rectangle * @param height defines the height of the clear rectangle From 15c9f1ff3fe7bd30e36d6ca8f3220fbc96092c12 Mon Sep 17 00:00:00 2001 From: sebavan Date: Thu, 12 May 2022 18:20:53 +0200 Subject: [PATCH 2/2] fix engine factory returning ThinEngine --- packages/dev/core/src/Engines/engineFactory.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/dev/core/src/Engines/engineFactory.ts b/packages/dev/core/src/Engines/engineFactory.ts index 5342e4a6b61..6fb931d24dd 100644 --- a/packages/dev/core/src/Engines/engineFactory.ts +++ b/packages/dev/core/src/Engines/engineFactory.ts @@ -1,6 +1,5 @@ import { Engine } from "./engine"; import { NullEngine } from "./nullEngine"; -import type { ThinEngine } from "./thinEngine"; import { WebGPUEngine } from "./webgpuEngine"; /** @@ -13,7 +12,7 @@ export class EngineFactory { * @param options Defines the options passed to the engine to create the context dependencies * @returns a promise that resolves with the created engine */ - public static CreateAsync(canvas: HTMLCanvasElement, options: any): Promise { + public static CreateAsync(canvas: HTMLCanvasElement, options: any): Promise { return WebGPUEngine.IsSupportedAsync.then((supported) => { if (supported) { return WebGPUEngine.CreateAsync(canvas, options);