Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootcamp Errors #18

Open
townsnic opened this issue Mar 1, 2024 · 0 comments
Open

Bootcamp Errors #18

townsnic opened this issue Mar 1, 2024 · 0 comments

Comments

@townsnic
Copy link

townsnic commented Mar 1, 2024

Some bootcamp issues I've found, whether grammatical or in the code. Each one is formatted as the page heading followed by the error...if you ctrl f it should be easy to find. Different page headings are bolded. Let me know if there are any that don't make sense.

Components -> References
the the

Components
GDS layers are tuples of ints, but if we use only one number it assumes
we've provided the layer number and that the other number, the datatype,
is 0
This is false. It throws an error if there is only one value. This occurs several times.

GDS to Meep
from gdsfactory.simulation.gmeep.get_simulation import get_simulation, get_meep_geometry_from_component
Should be gplugins.gmeep...

Also in second block
Plot the s-parameters
gf.simulation.plot.plot_sparameters(sp)
Should be
from gplugins import plot
Plot the s-parameters
plot.plot_sparameters(sp)

Polarization
red bield

Improving the ray-optic model
waveguide waveguide

Supported modes
anagle

Waveguide Modes
perpindicular (occurs a couple of times)

Directional couplers
overlap should be overlaps in the first paragraph

“odd”/antisymmetric, - this is just weird, remove the quotes and the comma

even/symmetric, - again, no comma

Process Design Kits
buit in

Mach-Zehnder Interferometers
A SAX circuit contains a netlist, which is a collection of component instances, their connections, and exposed ports; and a list of models, which...
Weird grammar, should be
A SAX circuit contains a netlist, which is a collection of component instances, their connections and exposed ports, and a list of models, which...

The second element of the returned tuple is a information object - should be an not a

gf.get_generic_pdk does not work

phasae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant